Bug 161005 - Migrate RenderText::stringView() to unsigneds
Summary: Migrate RenderText::stringView() to unsigneds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-19 12:05 PDT by Myles C. Maxfield
Modified: 2016-08-19 14:41 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.81 KB, patch)
2016-08-19 12:06 PDT, Myles C. Maxfield
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-08-19 12:05:49 PDT
Migrate RenderText::stringView() to unsigneds
Comment 1 Myles C. Maxfield 2016-08-19 12:06:47 PDT
Created attachment 286466 [details]
Patch
Comment 2 Dean Jackson 2016-08-19 14:20:20 PDT
Comment on attachment 286466 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286466&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:886
> +                ASSERT(run->m_stop != -1);

Isn't this unsigned now in your other patch?
Comment 3 Myles C. Maxfield 2016-08-19 14:41:53 PDT
Committed r204653: <http://trac.webkit.org/changeset/204653>