Rename LifecycleCallbackQueue and CustomElementLifecycleProcessingStack to CustomElementReactionQueue and CustomElementReactionStack per the latest spec: https://html.spec.whatwg.org/#custom-element-reactions
Created attachment 286434 [details] Renamed classes
Created attachment 286436 [details] Fixed CMake builds
It’s kind of annoying that we have CustomElement*s*Registry and then CustomElementReactionQueue but I guess that matches the spec. I hate plural/singular difference in English so much :(
Comment on attachment 286436 [details] Fixed CMake builds View in context: https://bugs.webkit.org/attachment.cgi?id=286436&action=review r=me > Source/WebCore/bindings/js/JSCustomElementsRegistryCustom.cpp:42 > +static JSObject* getCallback(ExecState& state, JSObject& prototype, const Identifier& id) maybe getCustomElementCallback() ? I don't feel strongly, land either way. > Source/WebCore/dom/CustomElementReactionQueue.cpp:43 > +class CustomElementReactionQueueItem { In a follow up, it could be nice to move this class under CustomElementReactionQueue and rename it to "Item".
Comment on attachment 286436 [details] Fixed CMake builds View in context: https://bugs.webkit.org/attachment.cgi?id=286436&action=review >> Source/WebCore/bindings/js/JSCustomElementsRegistryCustom.cpp:42 >> +static JSObject* getCallback(ExecState& state, JSObject& prototype, const Identifier& id) > > maybe getCustomElementCallback() ? I don't feel strongly, land either way. Sure, I was initially using that name and I thought it was too long. Fixed. >> Source/WebCore/dom/CustomElementReactionQueue.cpp:43 >> +class CustomElementReactionQueueItem { > > In a follow up, it could be nice to move this class under CustomElementReactionQueue and rename it to "Item". I don’t want to do that because then I have to pull in a whole bunch of headers in CustomElementReactionQueue.h
Committed r204652: <http://trac.webkit.org/changeset/204652>
Windows build fix in http://trac.webkit.org/projects/webkit/changeset/204655