Bug 160985 - REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
Summary: REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-18 17:01 PDT by Ryan Haddad
Modified: 2016-08-20 10:31 PDT (History)
6 users (show)

See Also:


Attachments
Patch (12.71 KB, patch)
2016-08-18 21:53 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (12.58 KB, patch)
2016-08-18 22:57 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (13.15 KB, patch)
2016-08-19 07:50 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (14.84 KB, patch)
2016-08-19 13:12 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (16.57 KB, patch)
2016-08-19 14:25 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-08-18 17:01:28 PDT
Running LayoutTests on ios-simulator became ~15 minutes slower between r204473 - r204483
Comment 1 Ryan Haddad 2016-08-18 17:02:49 PDT
I have not verified that it is the regression point, but https://trac.webkit.org/changeset/204477 seems like a suspect.
Comment 2 Ryan Haddad 2016-08-18 17:12:10 PDT
(In reply to comment #0)
> Running LayoutTests on ios-simulator became ~15 minutes slower between
> r204473 - r204483

https://trac.webkit.org/log/?verbose=on&rev=204483&stop_rev=204473
Comment 3 Simon Fraser (smfr) 2016-08-18 21:29:34 PDT
Happens because I removed a @memoized
Comment 4 Simon Fraser (smfr) 2016-08-18 21:53:34 PDT
Created attachment 286437 [details]
Patch
Comment 5 Alexey Proskuryakov 2016-08-18 22:18:05 PDT
Comment on attachment 286437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286437&action=review

Seems OK as a quick fix, r=me pending EWS.

> Tools/Scripts/webkitpy/port/base.py:43
> +import traceback

?
Comment 6 Simon Fraser (smfr) 2016-08-18 22:26:21 PDT
(In reply to comment #5)
> Comment on attachment 286437 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286437&action=review
> 
> Seems OK as a quick fix, r=me pending EWS.

Quick fix? Seems like a good long-term direction to me!

> > Tools/Scripts/webkitpy/port/base.py:43
> > +import traceback
> 
> ?

Was for debugging. Weill remove.
Comment 7 Simon Fraser (smfr) 2016-08-18 22:57:42 PDT
Created attachment 286439 [details]
Patch
Comment 8 Simon Fraser (smfr) 2016-08-19 07:50:48 PDT
Created attachment 286453 [details]
Patch
Comment 9 Alexey Proskuryakov 2016-08-19 09:26:24 PDT
Comment on attachment 286453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286453&action=review

Still seems to not work, per EWS.

> Tools/Scripts/webkitpy/layout_tests/views/printing.py:51
> -        optparse.make_option('--debug-rwt-logging', action='store_true', default=False,
> +        optparse.make_option('--debug-rwt-logging', action='store_true', default=True,

?
Comment 10 Simon Fraser (smfr) 2016-08-19 10:16:06 PDT
(In reply to comment #9)
> Comment on attachment 286453 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286453&action=review
> 
> Still seems to not work, per EWS.
> 
> > Tools/Scripts/webkitpy/layout_tests/views/printing.py:51
> > -        optparse.make_option('--debug-rwt-logging', action='store_true', default=False,
> > +        optparse.make_option('--debug-rwt-logging', action='store_true', default=True,
> 
> ?

Just trying to get more data from EWS.
Comment 11 Alexey Proskuryakov 2016-08-19 10:20:45 PDT
This is the current state of ews125 - no simulators are running.

== Device Types ==
iPhone 4s (com.apple.CoreSimulator.SimDeviceType.iPhone-4s)
iPhone 5 (com.apple.CoreSimulator.SimDeviceType.iPhone-5)
iPhone 5s (com.apple.CoreSimulator.SimDeviceType.iPhone-5s)
iPhone 6 (com.apple.CoreSimulator.SimDeviceType.iPhone-6)
iPhone 6 Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-6-Plus)
iPhone 6s (com.apple.CoreSimulator.SimDeviceType.iPhone-6s)
iPhone 6s Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-6s-Plus)
iPad 2 (com.apple.CoreSimulator.SimDeviceType.iPad-2)
iPad Retina (com.apple.CoreSimulator.SimDeviceType.iPad-Retina)
iPad Air (com.apple.CoreSimulator.SimDeviceType.iPad-Air)
iPad Air 2 (com.apple.CoreSimulator.SimDeviceType.iPad-Air-2)
iPad Pro (com.apple.CoreSimulator.SimDeviceType.iPad-Pro)
Apple TV 1080p (com.apple.CoreSimulator.SimDeviceType.Apple-TV-1080p)
Apple Watch - 38mm (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-38mm)
Apple Watch - 42mm (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-42mm)
== Runtimes ==
iOS 9.3 (9.3 - 13E230) (com.apple.CoreSimulator.SimRuntime.iOS-9-3)
tvOS 9.2 (9.2 - 13Y227) (com.apple.CoreSimulator.SimRuntime.tvOS-9-2)
watchOS 2.2 (2.2 - 13V143) (com.apple.CoreSimulator.SimRuntime.watchOS-2-2)
== Devices ==
-- iOS 9.3 --
    iPhone 4s (83B9CBEF-DFE1-49ED-ADE6-8A2B1EEDC8E0) (Shutdown)
    iPhone 5 (FD7F1ADC-EC11-4CC7-9068-DA72F55623D2) (Shutdown)
    iPhone 5s (0ACB0ECB-9E0B-4FC5-9468-833E7F06A0DC) (Shutdown)
    iPhone 5s WebKit Tester0 (E5F27726-990D-49C8-846A-F5B58AD8854F) (Shutdown)
    iPhone 5s WebKit Tester1 (E82550EA-1636-4A39-A9E9-C0D596C5BFAE) (Shutdown)
    iPhone 5s WebKit Tester10 (7143A314-7F75-4177-9714-0334BD600C83) (Shutdown)
    iPhone 5s WebKit Tester11 (933B4084-BCDF-49F0-BE66-4222B2445A7D) (Shutdown)
    iPhone 5s WebKit Tester2 (709358B7-66C2-4FF9-9C9E-F7CF36A35EE9) (Shutdown)
    iPhone 5s WebKit Tester3 (BFBEA99B-782D-47CB-82A2-FF743F16BD1E) (Shutdown)
    iPhone 5s WebKit Tester4 (BD292BE8-FD72-43C6-90F1-781394EAD50C) (Shutdown)
    iPhone 5s WebKit Tester5 (B9FA4497-A16F-4344-A280-7A383958397E) (Shutdown)
    iPhone 5s WebKit Tester6 (C1F2311B-B143-4533-8D0D-0225AA752CA1) (Shutdown)
    iPhone 5s WebKit Tester7 (B0404AA8-015F-436D-99E9-7B6CC5096260) (Shutdown)
    iPhone 5s WebKit Tester8 (EB313F85-2B4D-43DE-8CCC-5870194EC637) (Shutdown)
    iPhone 5s WebKit Tester9 (5880BD0D-6C46-4ABF-A947-56DB7EF2C1B6) (Shutdown)
    iPhone 6 (203852CE-F118-4969-B3ED-251ACAA21502) (Shutdown)
    iPhone 6 Plus (C6F962E8-B96C-4464-8566-865A90F5A9A4) (Shutdown)
    iPhone 6s (DD1DC7A5-5C01-4B33-87C6-D05F104B05FD) (Shutdown)
    iPhone 6s Plus (4E269DE9-1F1E-44E1-AABD-4B024B9B3BEA) (Shutdown)
    iPad 2 (77567788-B685-42F8-89CB-46AD6BFDF8E0) (Shutdown)
    iPad Retina (0F339C3B-7D9A-4B01-8764-55F131BB3C5D) (Shutdown)
    iPad Air (5F2023DA-6A45-4ABE-B5C0-33475CA0E4F4) (Shutdown)
    iPad Air 2 (57646313-2838-428F-929F-0F8A30A2B298) (Shutdown)
    iPad Pro (9D51701E-8E4E-488E-8CA5-548C3A8BB718) (Shutdown)
-- tvOS 9.2 --
    Apple TV 1080p (DFFCCBBE-AC89-462C-BA9B-930684E691D6) (Shutdown)
-- watchOS 2.2 --
    Apple Watch - 38mm (B6C6C969-F0E9-4C82-9493-F91B47EB9DB1) (Shutdown)
    Apple Watch - 42mm (F3C10B08-4CB2-4E6C-A493-02C6A3D4BF5E) (Shutdown)
-- Unavailable: com.apple.CoreSimulator.SimRuntime.iOS-8-1 --
    iPhone 4s (8B292CBA-49C7-4ECB-9E82-12E39491E67B) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5 (08C0C496-6BA5-4BD2-A4B1-3B8B5B02631A) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s (8644BA8C-046F-4103-A3A4-2739F4CD3729) (Shutdown) (unavailable, runtime profile not found)
    iPhone 6 (111501E6-628A-4750-A2E2-19E7DE276E35) (Shutdown) (unavailable, runtime profile not found)
    iPhone 6 Plus (5E825F3F-280D-4F3A-931D-DB09855CD2CA) (Shutdown) (unavailable, runtime profile not found)
    iPad 2 (CF3C6F15-390F-4867-9EAE-7E8B771936FF) (Shutdown) (unavailable, runtime profile not found)
    iPad Retina (473D44A3-A089-4F57-BE70-F8971D4CA663) (Shutdown) (unavailable, runtime profile not found)
    iPad Air (10D99810-DB63-489D-93B5-B7A07B51A5A9) (Shutdown) (unavailable, runtime profile not found)
    Resizable iPad (1B0E493D-0D7E-4A61-BC31-A369452C4597) (Shutdown) (unavailable, runtime profile not found)
    Resizable iPhone (FFA4B3B3-0FE4-4FC0-A6FE-8E21A79EA0E9) (Shutdown) (unavailable, runtime profile not found)
-- Unavailable: com.apple.CoreSimulator.SimRuntime.iOS-8-3 --
    iPhone 4s (DAAFF837-C4FA-47BF-B408-93FD7726B07C) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5 (6E44A334-F69B-4413-BD36-D979A18BD657) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s (A85E861A-C6E6-4EEC-89BA-446B5F491F3D) (Shutdown) (unavailable, runtime profile not found)
    iPhone 6 (FFB4C290-7DB7-4C11-87DA-92D5C2A85184) (Shutdown) (unavailable, runtime profile not found)
    iPhone 6 Plus (13813494-1317-4139-8073-9D0C8F61CC5A) (Shutdown) (unavailable, runtime profile not found)
    iPad 2 (665C1FAC-1202-4E99-8065-C92EDCCAA495) (Shutdown) (unavailable, runtime profile not found)
    iPad Retina (A353E090-0900-4D9B-B627-F16DB5503333) (Shutdown) (unavailable, runtime profile not found)
    iPad Air (6787B04E-59B2-4062-B64F-BC4A918931AE) (Shutdown) (unavailable, runtime profile not found)
    Resizable iPad (5D71BC25-ACEE-4158-9937-AAA82AFFF1FB) (Shutdown) (unavailable, runtime profile not found)
    Resizable iPhone (DA3187BA-ABEF-4969-8E4B-57AF64A1C667) (Shutdown) (unavailable, runtime profile not found)
-- Unavailable: com.apple.CoreSimulator.SimRuntime.iOS-8-4 --
    iPhone 4s (7BD1F4C4-EE5C-4D6D-B372-8C1C30843199) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5 (3044E55F-5DFC-40D4-B048-DDC3997D6972) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s (122B15DA-734B-446B-9F79-E54F36B74675) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s For WebKit Development (86E43F77-6B8E-4FB9-8C0E-0CAF0C2A9DDC) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester (4D8F842A-9723-474B-9AD8-DC38B301339A) (Shutdown) (unavailable, runtime profile not found)
    iPhone 6 (C204DAD5-AE3B-474E-BEA0-02834759F652) (Shutdown) (unavailable, runtime profile not found)
    iPhone 6 Plus (FF45F1DB-945F-4A89-93CF-26998EAC2819) (Shutdown) (unavailable, runtime profile not found)
    iPad 2 (57C99C31-B74E-42E4-A252-217A16C7F6EB) (Shutdown) (unavailable, runtime profile not found)
    iPad Retina (8CDAD1FF-5883-4E71-B671-30585A8F0C0C) (Shutdown) (unavailable, runtime profile not found)
    iPad Air (AB4C2357-0D04-405E-BD44-B9FE80EB610F) (Shutdown) (unavailable, runtime profile not found)
    Resizable iPad (25E3B72F-53A8-48DA-AF65-38795C85D694) (Shutdown) (unavailable, runtime profile not found)
    Resizable iPhone (AEA70BA4-3350-4A99-89AA-89BAB9F7C6C6) (Shutdown) (unavailable, runtime profile not found)
-- Unavailable: com.apple.CoreSimulator.SimRuntime.iOS-9-0 --
    iPhone 4s (6E8ED0A6-4294-48CF-B70F-2BC63DB20552) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5 (18C215D6-C53C-45FA-8EA1-F8D923A44AB0) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s (9932D775-7EFD-480D-85D4-7707E33156AC) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s For WebKit Development (D8CE947E-34B0-4A6F-BFE5-650470C3EDAC) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester (11F1268E-E5F1-4D63-8275-A6222F051594) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester0 (648B521A-CA80-4BEC-8B22-39829CFF76E1) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester1 (980261D6-F1F6-4257-9168-2C05036B3C96) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester10 (D40A812C-C8DA-44E0-B623-2DED9527678B) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester2 (A98A6C9A-C7ED-4F08-98A1-3BB7AD1E8849) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester3 (74069935-BAC6-40A0-8093-332D4C0792E2) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester4 (59C85241-A2F2-4F0C-8EB4-87CADF09C7B8) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester5 (1003CE74-D8F6-41B3-AEAB-B525A052FE5C) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester6 (2B02AE8C-19DB-41C6-A1AA-8690CA3E7FD4) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester7 (7D7170AF-6588-495D-9791-A17230218BDE) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester8 (9F32DA9E-9AFE-47AA-8198-E948E795F630) (Shutdown) (unavailable, runtime profile not found)
    iPhone 5s WebKit Tester9 (ED7480EB-9DEA-47CD-8FA0-51500A871BEF) (Shutdown) (unavailable, runtime profile not found)
    iPhone 6 (1A76F377-20A8-486F-9CC4-4FB400B9235B) (Shutdown) (unavailable, runtime profile not found)
    iPhone 6 Plus (06355E16-D584-4A4C-9526-BD44B560CD15) (Shutdown) (unavailable, runtime profile not found)
    iPhone 6s (9D6B6384-1FF9-4DF1-8CF5-011D12111409) (Shutdown) (unavailable, runtime profile not found)
    iPhone 6s Plus (C6F64325-A053-4985-913C-3927B8941019) (Shutdown) (unavailable, runtime profile not found)
    iPad 2 (435187DA-2E97-443F-BD6B-986D68F17953) (Shutdown) (unavailable, runtime profile not found)
    iPad Retina (BEB25059-F6D3-4152-B71E-0A8CF84AE470) (Shutdown) (unavailable, runtime profile not found)
    iPad Air (781E4C50-6E5E-4823-B870-F57DD29C7581) (Shutdown) (unavailable, runtime profile not found)
    iPad Air 2 (8E4B6AB0-F6D0-4762-967F-AFB6EA5C502B) (Shutdown) (unavailable, runtime profile not found)
-- Unavailable: com.apple.CoreSimulator.SimRuntime.watchOS-2-0 --
    Apple Watch - 38mm (883B45D5-0FCC-47C2-B6A1-C0BE1DCD99C1) (Shutdown) (unavailable, runtime profile not found)
    Apple Watch - 42mm (7C3F94B5-1540-46E3-AF58-EA3ED042D069) (Shutdown) (unavailable, runtime profile not found)
== Device Pairs ==
34D921D6-ECFD-4A23-8BEA-DF5547CF4C93 (active, disconnected)
    Watch: Apple Watch - 38mm (B6C6C969-F0E9-4C82-9493-F91B47EB9DB1) (Shutdown)
    Phone: iPhone 6s (DD1DC7A5-5C01-4B33-87C6-D05F104B05FD) (Shutdown)
C55D40F2-C98C-4067-8666-B7E40C4FFDB0 (active, disconnected)
    Watch: Apple Watch - 42mm (F3C10B08-4CB2-4E6C-A493-02C6A3D4BF5E) (Shutdown)
    Phone: iPhone 6s Plus (4E269DE9-1F1E-44E1-AABD-4B024B9B3BEA) (Shutdown)
EC2BF4ED-4CA5-4FC4-9726-3E1303213958 (unavailable)
    Watch: Apple Watch - 38mm (883B45D5-0FCC-47C2-B6A1-C0BE1DCD99C1) (Shutdown)
    Phone: iPhone 6 (1A76F377-20A8-486F-9CC4-4FB400B9235B) (Shutdown)
B667E539-594D-481D-B825-3399EB35C78C (unavailable)
    Watch: Apple Watch - 42mm (7C3F94B5-1540-46E3-AF58-EA3ED042D069) (Shutdown)
    Phone: iPhone 6 Plus (06355E16-D584-4A4C-9526-BD44B560CD15) (Shutdown)
Comment 12 Simon Fraser (smfr) 2016-08-19 13:12:21 PDT
Created attachment 286471 [details]
Patch
Comment 13 WebKit Commit Bot 2016-08-19 13:16:42 PDT
Attachment 286471 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/layout_tests/views/printing.py:51:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/Scripts/webkitpy/xcode/simulator.py:306:  whitespace before ']'  [pep8/E202] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Simon Fraser (smfr) 2016-08-19 14:25:23 PDT
Created attachment 286478 [details]
Patch
Comment 15 WebKit Commit Bot 2016-08-19 14:35:48 PDT
Attachment 286478 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/layout_tests/views/printing.py:51:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/Scripts/webkitpy/xcode/simulator.py:321:  whitespace before ']'  [pep8/E202] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Simon Fraser (smfr) 2016-08-19 15:15:15 PDT
https://trac.webkit.org/r204659
Comment 17 Ryan Haddad 2016-08-19 19:31:22 PDT
(In reply to comment #16)
> https://trac.webkit.org/r204659

It looks like this change may have caused simulator tests to fail during shutdown:

15:51:52.256 24455 xcrun simctl shutdown A187C905-270B-4587-89AD-1E612052A49B
An error was encountered processing the command (domain=com.apple.CoreSimulator.SimError, code=159):
Unable to shutdown device in current state: Shutdown

RuntimeError raised: "xcrun simctl shutdown" failed
Traceback (most recent call last):
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 81, in main
    run_details = run(port, options, args, stderr)
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 415, in run
    run_details = manager.run(args)
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 233, in run
    initial_results, retry_results, enabled_pixel_tests_in_retry = self._run_test_subset(default_device_tests, tests_to_skip)
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 274, in _run_test_subset
    self._clean_up_run()
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 327, in _clean_up_run
    self._port.clean_up_test_run()
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/port/ios.py", line 299, in clean_up_test_run
    self._remove_device(i)
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/port/ios.py", line 388, in _remove_device
    Simulator.remove_device(number)
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/xcode/simulator.py", line 338, in remove_device
    Simulator.delete_device(device_udid)
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/xcode/simulator.py", line 394, in delete_device
    Device.delete(udid)
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/xcode/simulator.py", line 244, in delete
    Device.shutdown(udid)
  File "/Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/Tools/Scripts/webkitpy/xcode/simulator.py", line 233, in shutdown
    raise RuntimeError('"xcrun simctl shutdown" failed')
RuntimeError: "xcrun simctl shutdown" failed
Comment 19 Ryan Haddad 2016-08-19 19:54:42 PDT
Reverted r204659 for reason:

This change appears to have caused ios-simulator LayoutTests to fail when shutting down the simulator

Committed r204672: <http://trac.webkit.org/changeset/204672>
Comment 20 Ryan Haddad 2016-08-19 21:07:22 PDT
(In reply to comment #19)
> Reverted r204659 for reason:
> 
> This change appears to have caused ios-simulator LayoutTests to fail when
> shutting down the simulator
> 
> Committed r204672: <http://trac.webkit.org/changeset/204672>

The rollout resolved the issue:
https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/8339
Comment 21 Simon Fraser (smfr) 2016-08-19 21:47:56 PDT
15:51:51.331 24455 _quit_ios_simulator killing all Simulator processes
15:51:52.255 24455 removing device 0 A187C905-270B-4587-89AD-1E612052A49B
15:51:52.256 24455 xcrun simctl shutdown A187C905-270B-4587-89AD-1E612052A49B
An error was encountered processing the command (domain=com.apple.CoreSimulator.SimError, code=159):
Unable to shutdown device in current state: Shutdown

I should probably just not raise an error if the 'xcrun simctl shutdown' fails. Looks like it's racing with simulator quitting, since I do check the device state before issuing the shutdown.
Comment 22 Simon Fraser (smfr) 2016-08-20 10:31:24 PDT
I re-landed after changing the check_call('xcrun simctl shutdown') to a call().
Comment 23 Simon Fraser (smfr) 2016-08-20 10:31:40 PDT
https://trac.webkit.org/changeset/204680