Bug 160981 – AX: iOS, Wrong axLabel on static text if heading has multiple children

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

When heading has multiple children, each static text child seems to have the axLabel to be the concatenation of all the heading children's labels.

<rdar://problem/27827108>

[Nan Wang]

Created attachment 286414 [details]
Patch

[Build Bot]

Comment on attachment 286414 [details]
Patch

Attachment 286414 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1895740

New failing tests:
fast/scrolling/ios/scroll-events-back-forward.html

[Build Bot]

Created attachment 286429 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Nan Wang]

Comment on attachment 286414 [details]
Patch

test failure is not related to this patch.

[chris fleizach]

Comment on attachment 286414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286414&action=review

> Source/WebCore/ChangeLog:9
> +        no alternate texts. So we shouldn't use accessibilityLable to check for user defined texts

no alternate "text." - text is already plural here

accessibilityLable -> accessibilityLabel

this description isn't very clear to me... what is the problem with calling axLabel? what does it return, that baseDescription does not

> LayoutTests/accessibility/ios-simulator/heading-with-aria-label.html:40
> +        // Also make sure when the heading has multiple children, we are not messing up with

"messing up" is too colloquial here. I would say

"When a heading has multiple children, ensure ..."

[Nan Wang]

Created attachment 286457 [details]
Patch

Update from review

[WebKit Commit Bot]

Comment on attachment 286457 [details]
Patch

Clearing flags on attachment: 286457

Committed r204645: <http://trac.webkit.org/changeset/204645>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.