Bug 160977 - [Cocoa] API::Number needs to be wrapped by an NSNumber
Summary: [Cocoa] API::Number needs to be wrapped by an NSNumber
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-18 15:19 PDT by mitz
Modified: 2016-08-18 19:49 PDT (History)
2 users (show)

See Also:


Attachments
Introduce WKNSNumber (20.42 KB, patch)
2016-08-18 15:31 PDT, mitz
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2016-08-18 15:19:07 PDT
<rdar://problem/27877735>

Currently API::Number objects are wrapped by WKObject, but that means that Objective-C clients can’t see their value.

Patch forthcoming.
Comment 1 mitz 2016-08-18 15:31:10 PDT
Created attachment 286403 [details]
Introduce WKNSNumber
Comment 2 WebKit Commit Bot 2016-08-18 15:33:55 PDT
Attachment 286403 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/Cocoa/WKNSNumber.h:35:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2016-08-18 16:12:57 PDT
Fixed in <https://trac.webkit.org/r204614>.
Comment 4 Hunseop Jeong 2016-08-18 19:49:35 PDT
Fix CMake build after r204614
Committed r204625: <http://trac.webkit.org/changeset/204625>