Bug 160974 - Switch order of URL constructor parameters
Summary: Switch order of URL constructor parameters
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-18 14:25 PDT by Alex Christensen
Modified: 2023-03-27 08:17 PDT (History)
3 users (show)

See Also:

Attachments
Patch (208.14 KB, patch)
2016-08-18 14:32 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (208.13 KB, patch)
2016-08-19 18:44 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (208.11 KB, patch)
2016-08-19 22:35 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (208.87 KB, patch)
2016-08-19 23:06 PDT, Alex Christensen 		mcatanzaro: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (828.81 KB, application/zip)
2016-08-19 23:49 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-yosemite (1.43 MB, application/zip)
2016-08-20 00:06 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews116 for mac-yosemite (2.20 MB, application/zip)
2016-08-20 00:20 PDT, Build Bot 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-08-18 14:25:38 PDT 
Switch order of URL constructor parameters
Comment 1 Alex Christensen 2016-08-18 14:32:28 PDT 
Created attachment 286396 [details]
Patch
Comment 2 Alex Christensen 2016-08-19 18:44:22 PDT 
Created attachment 286513 [details]
Patch
Comment 3 Alex Christensen 2016-08-19 22:35:09 PDT 
Created attachment 286528 [details]
Patch
Comment 4 Alex Christensen 2016-08-19 23:06:50 PDT 
Created attachment 286531 [details]
Patch
Comment 5 Build Bot 2016-08-19 23:49:06 PDT 
Comment on attachment 286531 [details]
Patch

Attachment 286531 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1905393

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2016-08-19 23:49:10 PDT 
Created attachment 286532 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-08-20 00:06:38 PDT 
Comment on attachment 286531 [details]
Patch

Attachment 286531 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1905535

New failing tests:
fast/forms/focus2.html
fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html
imported/w3c/web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument.html
imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-with-base.html
imported/w3c/web-platform-tests/XMLHttpRequest/open-url-base.htm
imported/w3c/web-platform-tests/dom/nodes/DOMImplementation-createDocument.html
fast/overflow/overflow_hidden.html
fast/dom/HTMLLinkElement/resolve-url-on-insertion.html
imported/w3c/web-platform-tests/dom/nodes/Node-properties.html
imported/w3c/web-platform-tests/dom/nodes/Document-constructor.html
fast/preloader/first-base-tag-wins.html
fast/url/idna2003.html
imported/w3c/web-platform-tests/domparsing/DOMParser-parseFromString-html.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/document-base-url.html
fast/url/host.html
imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-stringifier.html
fast/url/invalid-idn.html
fast/dom/HTMLAnchorElement/anchor-element-href-parsing.html
fast/dom/anchor-toString.html
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/fetch-src/alpha/base.html
Comment 8 Build Bot 2016-08-20 00:06:45 PDT 
Created attachment 286533 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-08-20 00:20:32 PDT 
Comment on attachment 286531 [details]
Patch

Attachment 286531 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1905579

New failing tests:
imported/w3c/web-platform-tests/dom/nodes/Node-properties.html
fast/forms/focus2.html
fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html
imported/w3c/web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument.html
imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-with-base.html
imported/w3c/web-platform-tests/dom/nodes/DOMImplementation-createDocument.html
fast/dom/HTMLAnchorElement/anchor-element-href-parsing.html
fast/dom/HTMLLinkElement/resolve-url-on-insertion.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/document-base-url.html
imported/w3c/web-platform-tests/dom/nodes/Document-constructor.html
fast/url/idna2003.html
imported/w3c/web-platform-tests/domparsing/DOMParser-parseFromString-html.html
fast/preloader/first-base-tag-wins.html
fast/url/host.html
imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-stringifier.html
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/fetch-src/alpha/base.html
fast/url/invalid-idn.html
imported/w3c/web-platform-tests/XMLHttpRequest/open-url-base.htm
fast/dom/anchor-toString.html
Comment 10 Build Bot 2016-08-20 00:20:35 PDT 
Created attachment 286534 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Brent Fulgham 2016-08-22 11:32:32 PDT 
Comment on attachment 286531 [details]
Patch

EWS is really unhappy with this patch!
Comment 12 Michael Catanzaro 2016-09-08 20:42:08 PDT 
Comment on attachment 286531 [details]
Patch

EWS is really unhappy with this patch!
Comment 13 Anne van Kesteren 2023-03-27 08:17:59 PDT 
I'm gonna assume that this has been overtaken by more recent URL refactoring efforts.