RESOLVED FIXED 160968
Add LLINT probe() macro for X86_64. 
https://bugs.webkit.org/show_bug.cgi?id=160968
Summary Add LLINT probe() macro for X86_64.
Mark Lam
Reported 2016-08-18 12:06:13 PDT
Patch coming.
Attachments
proposed patch. (2.24 KB, patch)
2016-08-18 12:09 PDT, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-08-18 12:09:42 PDT
Created attachment 286384 [details] proposed patch.
Geoffrey Garen
Comment 2 2016-08-18 12:55:52 PDT
Comment on attachment 286384 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=286384&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:466 > + push a0, a1 > + push a2, a3 > + push t0, t1 > + push t2, t3 > + push t4, t5 This looks unaligned. Please fix.
Mark Lam
Comment 3 2016-08-18 13:10:20 PDT
Comment on attachment 286384 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=286384&action=review Thanks for the review. Will land shortly. >> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:466 >> + push t4, t5 > > This looks unaligned. Please fix. These are pushing 5 pairs of registers. Since the alignment requirement is 16 bytes (i.e. the size of 2 registers), the required alignment is preserved.
Mark Lam
Comment 4 2016-08-18 13:27:53 PDT
Landed in r204607: <http://trac.webkit.org/r204607>.
Note You need to log in before you can comment on or make changes to this bug.