Bug 160967 - Move an NPAPI-only function from WebCore to WebKit
Summary: Move an NPAPI-only function from WebCore to WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-18 12:01 PDT by Anders Carlsson
Modified: 2016-08-19 13:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.89 KB, patch)
2016-08-18 12:02 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (14.92 KB, patch)
2016-08-18 12:15 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (16.06 KB, patch)
2016-08-18 12:17 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (16.06 KB, patch)
2016-08-18 12:17 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (16.97 KB, patch)
2016-08-18 13:04 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (16.97 KB, patch)
2016-08-18 14:01 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-08-18 12:01:33 PDT 
Move an NPAPI-only function from WebCore to WebKit
Comment 1 Anders Carlsson 2016-08-18 12:02:11 PDT 
Created attachment 286382 [details]
Patch
Comment 2 Anders Carlsson 2016-08-18 12:15:59 PDT 
Created attachment 286386 [details]
Patch
Comment 3 Anders Carlsson 2016-08-18 12:17:02 PDT 
Created attachment 286387 [details]
Patch
Comment 4 Anders Carlsson 2016-08-18 12:17:50 PDT 
Created attachment 286388 [details]
Patch
Comment 5 Anders Carlsson 2016-08-18 13:04:00 PDT 
Created attachment 286391 [details]
Patch
Comment 6 Anders Carlsson 2016-08-18 14:01:04 PDT 
Created attachment 286392 [details]
Patch
Comment 7 Anders Carlsson 2016-08-18 17:14:06 PDT 
Committed r204617: <http://trac.webkit.org/changeset/204617>
Comment 8 Darin Adler 2016-08-19 13:15:53 PDT 
Comment on attachment 286392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286392&action=review

> Source/WebKit/win/Plugins/PluginView.cpp:756
> +    , m_elementNPObject(nullptr)

Why not initialize this in the class definition instead?