Bug 160964 – [Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning

[Andy Estes]

Created attachment 286378 [details]
Patch

[Brent Fulgham]

Comment on attachment 286378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286378&action=review

It seems like we should have some TestWebKitAPI tests for this. Can you file a bug to create such a thing if they don't already exist?

> Source/WebCore/page/Settings.h:27
> +#pragma once

Nice!

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:43
> +static bool cookieStoragePartitioningEnabled;

Are you sure we don't want to initialize this to false just to avoid flakiness?

[Andy Estes]

(In reply to comment #2)
> Comment on attachment 286378 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286378&action=review
> 
> It seems like we should have some TestWebKitAPI tests for this. Can you file
> a bug to create such a thing if they don't already exist?

Agreed. I filed <https://bugs.webkit.org/show_bug.cgi?id=160966>.

> 
> > Source/WebCore/page/Settings.h:27
> > +#pragma once
> 
> Nice!
> 
> > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:43
> > +static bool cookieStoragePartitioningEnabled;
> 
> Are you sure we don't want to initialize this to false just to avoid
> flakiness?

Static variables are implicitly initialized to 0 (false).

Thanks for the review!

[WebKit Commit Bot]

Comment on attachment 286378 [details]
Patch

Clearing flags on attachment: 286378

Committed r204603: <http://trac.webkit.org/changeset/204603>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Anders Carlsson]

This needs to follow the SPI guidelines. Please prefix the setter/getter with an underscore.

[Andy Estes]

Reopening to attach new patch.

[Andy Estes]

Created attachment 286389 [details]
Follow SPI naming guidelines

[Andy Estes]

Created attachment 286390 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 286390 [details]
Patch for landing

Clearing flags on attachment: 286390

Committed r204606: <http://trac.webkit.org/changeset/204606>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.