Bug 160964 - [Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning
Summary: [Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-18 11:21 PDT by Andy Estes
Modified: 2016-08-18 12:57 PDT (History)
8 users (show)

See Also:


Attachments
Patch (16.49 KB, patch)
2016-08-18 11:30 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Follow SPI naming guidelines (2.77 KB, patch)
2016-08-18 12:22 PDT, Andy Estes
andersca: review+
aestes: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (2.82 KB, patch)
2016-08-18 12:35 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-08-18 11:21:11 PDT
[Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning
Comment 1 Andy Estes 2016-08-18 11:30:12 PDT
Created attachment 286378 [details]
Patch
Comment 2 Brent Fulgham 2016-08-18 11:38:32 PDT
Comment on attachment 286378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286378&action=review

It seems like we should have some TestWebKitAPI tests for this. Can you file a bug to create such a thing if they don't already exist?

> Source/WebCore/page/Settings.h:27
> +#pragma once

Nice!

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:43
> +static bool cookieStoragePartitioningEnabled;

Are you sure we don't want to initialize this to false just to avoid flakiness?
Comment 3 Andy Estes 2016-08-18 11:44:06 PDT
(In reply to comment #2)
> Comment on attachment 286378 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286378&action=review
> 
> It seems like we should have some TestWebKitAPI tests for this. Can you file
> a bug to create such a thing if they don't already exist?

Agreed. I filed <https://bugs.webkit.org/show_bug.cgi?id=160966>.

> 
> > Source/WebCore/page/Settings.h:27
> > +#pragma once
> 
> Nice!
> 
> > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:43
> > +static bool cookieStoragePartitioningEnabled;
> 
> Are you sure we don't want to initialize this to false just to avoid
> flakiness?

Static variables are implicitly initialized to 0 (false).

Thanks for the review!
Comment 4 WebKit Commit Bot 2016-08-18 12:00:58 PDT
Comment on attachment 286378 [details]
Patch

Clearing flags on attachment: 286378

Committed r204603: <http://trac.webkit.org/changeset/204603>
Comment 5 WebKit Commit Bot 2016-08-18 12:01:03 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Anders Carlsson 2016-08-18 12:08:44 PDT
This needs to follow the SPI guidelines. Please prefix the setter/getter with an underscore.
Comment 7 Andy Estes 2016-08-18 12:22:42 PDT
Reopening to attach new patch.
Comment 8 Andy Estes 2016-08-18 12:22:45 PDT
Created attachment 286389 [details]
Follow SPI naming guidelines
Comment 9 Andy Estes 2016-08-18 12:35:52 PDT
Created attachment 286390 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2016-08-18 12:57:19 PDT
Comment on attachment 286390 [details]
Patch for landing

Clearing flags on attachment: 286390

Committed r204606: <http://trac.webkit.org/changeset/204606>
Comment 11 WebKit Commit Bot 2016-08-18 12:57:24 PDT
All reviewed patches have been landed.  Closing bug.