Bug 160957 – [MediaStream] cleanup MediaConstraints

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Have MediaConstraints hold a constraint type enum rather than a string so the conversion only happens one time. Also make the RealtimeMediaSourceSupportedConstraints::constraintFromName and RealtimeMediaSourceSupportedConstraints::nameForConstraint methods static.

[Eric Carlson]

Created attachment 286368 [details]
Proposed patch.

[Antoine Quint]

Comment on attachment 286368 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=286368&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:212
> +        LOG(Media, "AVVideoCaptureSource::applyConstraints(%p), unable set frame rate to %f", this, frameRate.value());

Do we need this new log?

[Eric Carlson]

(In reply to comment #2)
> Comment on attachment 286368 [details]
> Proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286368&action=review
> 
> > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:212
> > +        LOG(Media, "AVVideoCaptureSource::applyConstraints(%p), unable set frame rate to %f", this, frameRate.value());
> 
> Do we need this new log?

We don't need it, but I think it is useful because it logs an error that may otherwise be difficult to track down.

[WebKit Commit Bot]

Comment on attachment 286368 [details]
Proposed patch.

Clearing flags on attachment: 286368

Committed r204595: <http://trac.webkit.org/changeset/204595>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.