Bug 160945 - Move WKSignedPublicKeyAndChallengeString into WebCore and make it proper C++
Summary: Move WKSignedPublicKeyAndChallengeString into WebCore and make it proper C++
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-17 11:46 PDT by Anders Carlsson
Modified: 2016-08-17 12:59 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.95 KB, patch)
2016-08-17 11:50 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (12.02 KB, patch)
2016-08-17 12:07 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (12.45 KB, patch)
2016-08-17 12:26 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-08-17 11:46:45 PDT 
Move WKSignedPublicKeyAndChallengeString into WebCore and make it proper C++
Comment 1 Anders Carlsson 2016-08-17 11:50:03 PDT 
Created attachment 286309 [details]
Patch
Comment 2 Anders Carlsson 2016-08-17 12:07:38 PDT 
Created attachment 286312 [details]
Patch
Comment 3 Anders Carlsson 2016-08-17 12:26:46 PDT 
Created attachment 286316 [details]
Patch
Comment 4 mitz 2016-08-17 12:40:37 PDT 
Comment on attachment 286316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286316&action=review

> Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm:72
> +    const CSSM_KEY *cssmPublicKey;

The * should go next to the type.

> Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm:76
> +    const CSSM_ACCESS_CREDENTIALS credentials { };

We normally don’t const-qualify local, non-static variables.

> Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm:104
> +    const CSSM_KEY *cssmPrivateKey;

Star on the wrong side.

> Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm:108
> +    const CSSM_ACCESS_CREDENTIALS *credentials;

Ditto.

> Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm:142
> +    // For security purposes, private keys imported by WebKit should not be accessible by 
> +    // all applications. (4126976) Passing nullptr to SecTrustedApplicationCreateFromPath tells
> +    // that function to assume the application bundle. Our access to the newly-created private
> +    // key is necessary to sign challange responses.

I don’t think the 4126976 reference is needed. I’d remove the first and last sentences of the comment.

> Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm:179
> +    ASSERT(challenge.length());

Isn’t this assertion wrong? We have a call site below that can pass us the empty string as a challenge.

> Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm:204
> +    signedPublicKeyAndChallenge.signature.Length *= 8;

Mystery 8.

> Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm:206
> +    CSSM_DATA encodedSignedPublicKeyAndChallenge {0, nullptr };

Missing space after the {.
Comment 5 mitz 2016-08-17 12:42:17 PDT 
Comment on attachment 286316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286316&action=review

> Source/WTF/wtf/spi/cocoa/SecuritySPI.h:33
> +#include <Security/keyTemplates.h>

I think this isn’t present in the Apple-internal iOS SDK.
Comment 6 Anders Carlsson 2016-08-17 12:59:38 PDT 
Committed r204567: <http://trac.webkit.org/changeset/204567>