Patch forthcoming.
<rdar://problem/27876652>
Created attachment 286290 [details] Make WKObject not inherit from NSObject Unfortunately, even NSProxy implements some NSObject methods, so we can’t inherit from NSProxy.
Comment on attachment 286290 [details] Make WKObject not inherit from NSObject Attachment 286290 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1886580 New failing tests: ietestcenter/css3/flexbox/flexbox-flex-001.htm
Created attachment 286296 [details] Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Created attachment 286308 [details] Make WKObject not inherit from NSObject
Attachment 286308 [details] did not pass style-queue: ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:32: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:33: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:34: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:35: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:36: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:37: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:38: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 286308 [details] Make WKObject not inherit from NSObject View in context: https://bugs.webkit.org/attachment.cgi?id=286308&action=review I really think we need tests for this - both for isEqualToString: and testing that weak pointers work. > Source/WebKit2/Shared/Cocoa/WKObject.mm:117 > + return selector ? ((id(*)(id, SEL))objc_msgSend)(self, selector) : nil; Can use wtfObjcMsgSend here. > Source/WebKit2/Shared/Cocoa/WKObject.mm:122 > + return selector ? ((id(*)(id, SEL, id))objc_msgSend)(self, selector, object) : nil; Can use wtfObjcMsgSend here. > Source/WebKit2/Shared/Cocoa/WKObject.mm:127 > + return selector ? ((id(*)(id, SEL, id, id))objc_msgSend)(self, selector, object1, object2) : nil; Can use wtfObjcMsgSend here.
Created attachment 286313 [details] Make WKObject not inherit from NSObject
Attachment 286313 [details] did not pass style-queue: ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:32: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:33: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:34: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:35: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:36: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:37: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:38: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 286314 [details] Make WKObject not inherit from NSObject
Attachment 286314 [details] did not pass style-queue: ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:32: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:33: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:34: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:35: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:36: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:37: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Platform/spi/Cocoa/objcSPI.h:38: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 286314 [details] Make WKObject not inherit from NSObject View in context: https://bugs.webkit.org/attachment.cgi?id=286314&action=review > Source/WebKit2/Shared/Cocoa/WKObject.mm:188 > + if (_objc_rootReleaseWasZero(self)) { Maybe make this an early return?
Fixed in <https://trac.webkit.org/r204565>.