Bug 160936 - [CSS] The parser should not get rid of empty namespace specification in front of element name selectors
Summary: [CSS] The parser should not get rid of empty namespace specification in front...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-17 00:12 PDT by Benjamin Poulain
Modified: 2016-08-17 23:24 PDT (History)
1 user (show)

See Also:

Attachments
Patch (37.80 KB, patch)
2016-08-17 00:20 PDT, Benjamin Poulain 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-08-17 00:12:04 PDT 
[CSS] The parser should not get rid of empty namespace specification in front of element name selectors
Comment 1 Benjamin Poulain 2016-08-17 00:20:04 PDT 
Created attachment 286286 [details]
Patch
Comment 2 Chris Dumez 2016-08-17 14:26:03 PDT 
Comment on attachment 286286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286286&action=review

r=me

> Source/WebCore/css/CSSGrammar.y.in:1168
> +    '|' { $$.init(const_cast<LChar*>(reinterpret_cast<const LChar*>("")), 0); }

maybe a static LChar as the line below to avoid all this casting that looks unsafe?
Comment 3 Benjamin Poulain 2016-08-17 23:24:17 PDT 
Committed r204591: <http://trac.webkit.org/changeset/204591>