WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
160923
Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
https://bugs.webkit.org/show_bug.cgi?id=160923
Summary
Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related ...
Simon Fraser (smfr)
Reported
2016-08-16 17:24:59 PDT
Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
Attachments
Patch
(31.81 KB, patch)
2016-08-16 17:27 PDT
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2016-08-16 17:27:56 PDT
Created
attachment 286238
[details]
Patch
WebKit Commit Bot
Comment 2
2016-08-16 17:30:05 PDT
Attachment 286238
[details]
did not pass style-queue: ERROR: Source/WebKit/win/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit/win/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 8 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3
2016-08-16 17:32:41 PDT
Comment on
attachment 286238
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=286238&action=review
> Source/WebCore/ChangeLog:8 > + didLayout(LayoutMilestones) -> didReachLayoutMilestone(LayoutMilestones)
Tabs?
Simon Fraser (smfr)
Comment 4
2016-08-19 11:51:28 PDT
https://trac.webkit.org/r204637
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug