Bug 160919 - Add support for ShadowRoot.mode attribute
Summary: Add support for ShadowRoot.mode attribute
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#interfac...
Keywords: WebExposed
Depends on:
Blocks: 148695
  Show dependency treegraph
Reported: 2016-08-16 16:14 PDT by Chris Dumez
Modified: 2016-08-16 17:27 PDT (History)
3 users (show)

See Also:

Patch (21.83 KB, patch)
2016-08-16 16:26 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (21.89 KB, patch)
2016-08-16 16:56 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-08-16 16:14:54 PDT
Add support for ShadowRoot.mode attribute:
- https://dom.spec.whatwg.org/#interface-shadowroot
Comment 1 Chris Dumez 2016-08-16 16:26:23 PDT
Created attachment 286230 [details]
Comment 2 Ryosuke Niwa 2016-08-16 16:54:45 PDT
Comment on attachment 286230 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=286230&action=review

> Source/WebCore/dom/ShadowRoot.idl:37
> +enum ShadowRootMode { "user-agent", "closed", "open" };

Maybe we should add a comment that "user-agent" is a WebKit extension that should never be exposed to the Web?
Comment 3 Chris Dumez 2016-08-16 16:56:42 PDT
Created attachment 286234 [details]
Comment 4 WebKit Commit Bot 2016-08-16 17:27:12 PDT
Comment on attachment 286234 [details]

Clearing flags on attachment: 286234

Committed r204543: <http://trac.webkit.org/changeset/204543>
Comment 5 WebKit Commit Bot 2016-08-16 17:27:17 PDT
All reviewed patches have been landed.  Closing bug.