Bug 160912 - [JSC] Update the documentation of B3's Return opcode
Summary: [JSC] Update the documentation of B3's Return opcode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-16 14:43 PDT by Benjamin Poulain
Modified: 2016-08-16 19:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2016-08-16 14:44 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (1.92 KB, patch)
2016-08-16 15:10 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-08-16 14:43:58 PDT 
[JSC] Update the documentation of B3's Return opcode
Comment 1 Benjamin Poulain 2016-08-16 14:44:43 PDT 
Created attachment 286206 [details]
Patch
Comment 2 Filip Pizlo 2016-08-16 15:06:47 PDT 
Comment on attachment 286206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286206&action=review

> Websites/webkit.org/docs/b3/intermediate-representation.html:598
>        <dt>Void Return(T)</dt>

Can you do something here to hint that the value is optional?  Maybe:

Void Return(T?)

or:

Void Return(T <i>(optional)</i>)
Comment 3 Benjamin Poulain 2016-08-16 15:10:28 PDT 
Created attachment 286211 [details]
Patch
Comment 4 WebKit Commit Bot 2016-08-16 19:02:43 PDT 
Comment on attachment 286211 [details]
Patch

Clearing flags on attachment: 286211

Committed r204546: <http://trac.webkit.org/changeset/204546>
Comment 5 WebKit Commit Bot 2016-08-16 19:02:47 PDT 
All reviewed patches have been landed.  Closing bug.