Bug 160900 - Removed Objective-C specific attributes from IDL, made conditionals more consistent
Summary: Removed Objective-C specific attributes from IDL, made conditionals more cons...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-16 08:49 PDT by Darin Adler
Modified: 2016-08-20 19:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (116.88 KB, patch)
2016-08-16 08:53 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (108.97 KB, patch)
2016-08-20 18:05 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (108.96 KB, patch)
2016-08-20 18:19 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (109.70 KB, patch)
2016-08-20 19:07 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-08-16 08:49:10 PDT 
Removed Objective-C specific attributes from IDL, made conditionals more consistent
Comment 1 Darin Adler 2016-08-16 08:53:29 PDT 
Created attachment 286177 [details]
Patch
Comment 2 Darin Adler 2016-08-18 14:24:50 PDT 
Comment on attachment 286177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286177&action=review

> Source/WebCore/dom/KeyboardEvent.idl:59
> +        optional boolean shiftKey = false, optional boolean metaKey = false,

Oops, this should end with "optional boolean altGraphKey = false);" and I think that’s why all the builds are failing!
Comment 3 Darin Adler 2016-08-20 18:05:07 PDT 
Created attachment 286547 [details]
Patch
Comment 4 Darin Adler 2016-08-20 18:05:34 PDT 
Hey Sam, looks like you just did this, so my new patch is much reduced after merging with your change.
Comment 5 Darin Adler 2016-08-20 18:19:37 PDT 
Created attachment 286548 [details]
Patch
Comment 6 Sam Weinig 2016-08-20 18:31:34 PDT 
Comment on attachment 286548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286548&action=review

> Source/WebCore/dom/Node.idl:75
> +    readonly attribute DOMString? namespaceURI;
> +    [SetterRaisesException] attribute DOMString? prefix;
> +    readonly attribute DOMString? localName;

These seem to be additions.  I think these may have moved to element recently-isa.
Comment 7 Darin Adler 2016-08-20 19:03:51 PDT 
Oops, they did move to Attr and Element. Let me fix that.
Comment 8 Darin Adler 2016-08-20 19:07:47 PDT 
Created attachment 286549 [details]
Patch
Comment 9 Darin Adler 2016-08-20 19:23:39 PDT 
Committed r204687: <http://trac.webkit.org/changeset/204687>