Bug 160899 – [EFL] Bump efl version from 1.17 to 1.18

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

efl 1.18 is released recently. Let's use it for ewebkit.

[Gyuyoung Kim]

Created attachment 286176 [details]
Patch

[Gyuyoung Kim]

Created attachment 286252 [details]
Patch

[Gyuyoung Kim]

Created attachment 286257 [details]
Patch

[Gyuyoung Kim]

Created attachment 286258 [details]
Patch

[Gyuyoung Kim]

Created attachment 286267 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 286267 [details]
Patch

Clearing flags on attachment: 286267

Committed r204559: <http://trac.webkit.org/changeset/204559>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

It seems sudo Tools/efl/install-dependencies should be run
on EFL bots after this patch.

[Csaba Osztrogonác]

Comment on attachment 286267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286267&action=review

> Tools/efl/jhbuild.modules:172
> -             autogenargs="--disable-fribidi --disable-audio --disable-libmount --disable-physics --enable-lua-old --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-abb">
> +             autogenargs="--disable-fribidi --disable-audio --disable-libmount --disable-physics --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-abb">
>      <dependencies>

--enable-lua-old was added previously to be able to build EFL on AArch64,
because LuaJIT wasn't supported on it that time. Do you know if it is 
supported now, or EFL intentionally dropped AArch64 build support?

> Tools/efl/jhbuild.modules:-180
> -      <patch file="ecore_remove_warnings.patch" strip="1"/>

Please remove Tools/efl/patches/ecore_remove_warnings.patch file too if you don't need to patch EFL anymore.

[Gyuyoung Kim]

(In reply to comment #8)
> It seems sudo Tools/efl/install-dependencies should be run
> on EFL bots after this patch.

I missed to install the dependencies on perf bot. Now it is installed.

[Gyuyoung Kim]

(In reply to comment #9)
> Comment on attachment 286267 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286267&action=review
> 
> > Tools/efl/jhbuild.modules:172
> > -             autogenargs="--disable-fribidi --disable-audio --disable-libmount --disable-physics --enable-lua-old --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-abb">
> > +             autogenargs="--disable-fribidi --disable-audio --disable-libmount --disable-physics --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-abb">
> >      <dependencies>
> 
> --enable-lua-old was added previously to be able to build EFL on AArch64,
> because LuaJIT wasn't supported on it that time. Do you know if it is 
> supported now, or EFL intentionally dropped AArch64 build support?

I was noticed it when bumping efl. There is build break when using "--enable-lua-old" option with efl-1.18. That's why I removed it. Anyway I don't have to build EFL on ARM environment. So could you check it if current version can be built on ARM ?

> > Tools/efl/jhbuild.modules:-180
> > -      <patch file="ecore_remove_warnings.patch" strip="1"/>
> 
> Please remove Tools/efl/patches/ecore_remove_warnings.patch file too if you
> don't need to patch EFL anymore.

ok, let me remove it or update it.

[Csaba Osztrogonác]

(In reply to comment #11)
> (In reply to comment #9)
> > Comment on attachment 286267 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=286267&action=review
> > 
> > > Tools/efl/jhbuild.modules:172
> > > -             autogenargs="--disable-fribidi --disable-audio --disable-libmount --disable-physics --enable-lua-old --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-abb">
> > > +             autogenargs="--disable-fribidi --disable-audio --disable-libmount --disable-physics --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-abb">
> > >      <dependencies>
> > 
> > --enable-lua-old was added previously to be able to build EFL on AArch64,
> > because LuaJIT wasn't supported on it that time. Do you know if it is 
> > supported now, or EFL intentionally dropped AArch64 build support?
> 
> I was noticed it when bumping efl. There is build break when using
> "--enable-lua-old" option with efl-1.18. That's why I removed it. Anyway I
> don't have to build EFL on ARM environment. So could you check it if current
> version can be built on ARM ?

I have only old AArch64 systems (14.04/14.10) which don't have LuaJIT at all,
so the current version won't build as is. I tried with --enable-lua-old, but
I think I got the same warning you got:

lib/edje/edje_private.h:33:17: fatal error: lua.h: No such file or directory
#include <lua.h>

It is obviously a bug in the EFL configure scripts.