Add tests for https://trac.webkit.org/changeset/204502.
Created attachment 286174 [details] Patch
Comment on attachment 286174 [details] Patch Looks good! r=me.
Comment on attachment 286174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286174&action=review > Source/WebCore/platform/graphics/win/FontCacheWin.cpp:99 > +WEBCORE_EXPORT void appendLinkedFonts(WCHAR* linkedFonts, unsigned length, Vector<String>* result) There is no way to test this without exporting the function? This seems suspicious.
(In reply to comment #3) > Comment on attachment 286174 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286174&action=review > > > Source/WebCore/platform/graphics/win/FontCacheWin.cpp:99 > > +WEBCORE_EXPORT void appendLinkedFonts(WCHAR* linkedFonts, unsigned length, Vector<String>* result) > > There is no way to test this without exporting the function? This seems > suspicious. Since we have a separate test executable for WebCore, I thought this was the way to do it. I might have missed something, though. Thanks for looking into this :-)
(In reply to comment #2) > Comment on attachment 286174 [details] > Patch > > Looks good! r=me. Thanks for reviewing!
(In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 286174 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=286174&action=review > > > > > Source/WebCore/platform/graphics/win/FontCacheWin.cpp:99 > > > +WEBCORE_EXPORT void appendLinkedFonts(WCHAR* linkedFonts, unsigned length, Vector<String>* result) > > > > There is no way to test this without exporting the function? This seems > > suspicious. > > Since we have a separate test executable for WebCore, I thought this was the > way to do it. I might have missed something, though. > > Thanks for looking into this :-) I mean, isn't there a way a regular layout test can trigger this code path?
(In reply to comment #6) > (In reply to comment #4) > > (In reply to comment #3) > > > Comment on attachment 286174 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=286174&action=review > > > > > > > Source/WebCore/platform/graphics/win/FontCacheWin.cpp:99 > > > > +WEBCORE_EXPORT void appendLinkedFonts(WCHAR* linkedFonts, unsigned length, Vector<String>* result) > > > > > > There is no way to test this without exporting the function? This seems > > > suspicious. > > > > Since we have a separate test executable for WebCore, I thought this was the > > way to do it. I might have missed something, though. > > > > Thanks for looking into this :-) > > I mean, isn't there a way a regular layout test can trigger this code path? Normally, there will be a comma in the linked font list, since this is read from the Windows registry. I think it would be possible to write a layout test for this, but it will require a bit more work.
Comment on attachment 286174 [details] Patch Clearing flags on attachment: 286174 Committed r204558: <http://trac.webkit.org/changeset/204558>
All reviewed patches have been landed. Closing bug.