Bug 160888 - Simplify SocketStreamError
Summary: Simplify SocketStreamError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-15 19:53 PDT by Alex Christensen
Modified: 2016-08-16 00:56 PDT (History)
1 user (show)

See Also:

Attachments
Patch (31.04 KB, patch)
2016-08-15 19:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (32.76 KB, patch)
2016-08-15 20:39 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (32.78 KB, patch)
2016-08-16 00:17 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-08-15 19:53:57 PDT 
Simplify SocketStreamError
Comment 1 Alex Christensen 2016-08-15 19:55:49 PDT 
Created attachment 286139 [details]
Patch
Comment 2 Alex Christensen 2016-08-15 20:39:05 PDT 
Created attachment 286144 [details]
Patch
Comment 3 Darin Adler 2016-08-15 23:02:37 PDT 
Comment on attachment 286144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286144&action=review

> Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp:117
> +        handle->didFail(SocketStreamError(error->code, String(), String(error->message)));

Do we really need to cast the second thing to String?
Comment 4 Alex Christensen 2016-08-16 00:17:43 PDT 
Created attachment 286159 [details]
Patch
Comment 5 WebKit Commit Bot 2016-08-16 00:56:47 PDT 
Comment on attachment 286159 [details]
Patch

Clearing flags on attachment: 286159

Committed r204501: <http://trac.webkit.org/changeset/204501>
Comment 6 WebKit Commit Bot 2016-08-16 00:56:52 PDT 
All reviewed patches have been landed.  Closing bug.