Bug 160885 – Web Inspector: Select elements in DOM hierarchy are misaligned

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

It seems to be horizontally offset by a few pixels.  Very irksome...

[Radar WebKit Bug Importer]

<rdar://problem/27858089>

[Devin Rousso]

Created attachment 286126 [details]
Patch

[Matt Baker]

No screenshot?!

(╯°□°）╯︵ ┻━┻

[Joseph Pecoraro]

Comment on attachment 286126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286126&action=review

> Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css:100
> -    left: 10px;
> +    left: 12px;

We should be very specific here:

  • On my Non-retina OS X El Capitan machine this needs to be left: 13px to align perfectly with the text.
  • On my Retina macOS Sierra machine this needs to be left: 13px  to align perfectly with the text.

What system were you on where 12px was optimal. Maybe we need to make platform/configuration specific values? Or maybe there is a system setting that nudges it 1px for you?

[Devin Rousso]

Created attachment 286278 [details]
Patch

[Devin Rousso]

(In reply to comment #4)
> We should be very specific here:
> 
>   • On my Non-retina OS X El Capitan machine this needs to be left: 13px to
> align perfectly with the text.
>   • On my Retina macOS Sierra machine this needs to be left: 13px  to align
> perfectly with the text.
> 
> What system were you on where 12px was optimal. Maybe we need to make
> platform/configuration specific values? Or maybe there is a system setting
> that nudges it 1px for you?

Not really sure why, but it looked right when I tried it yesterday.  I tried moving the window around and changing resolution, but 13px always looked exactly right ¯\_(ツ)_/¯

[Devin Rousso]

Created attachment 286326 [details]
[Image] After Patch is applied

[Timothy Hatcher]

Comment on attachment 286278 [details]
Patch

Yes!

[WebKit Commit Bot]

Comment on attachment 286278 [details]
Patch

Clearing flags on attachment: 286278

Committed r204571: <http://trac.webkit.org/changeset/204571>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.