Bug 160885 - Web Inspector: Select elements in DOM hierarchy are misaligned
Summary: Web Inspector: Select elements in DOM hierarchy are misaligned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-15 18:00 PDT by Devin Rousso
Modified: 2016-08-17 14:22 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.32 KB, patch)
2016-08-15 18:01 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (1.32 KB, patch)
2016-08-16 23:00 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (757.15 KB, image/gif)
2016-08-17 13:52 PDT, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-08-15 18:00:32 PDT
It seems to be horizontally offset by a few pixels.  Very irksome...
Comment 1 Radar WebKit Bug Importer 2016-08-15 18:00:47 PDT
<rdar://problem/27858089>
Comment 2 Devin Rousso 2016-08-15 18:01:33 PDT
Created attachment 286126 [details]
Patch
Comment 3 Matt Baker 2016-08-15 18:46:56 PDT
No screenshot?!

(╯°□°)╯︵ ┻━┻
Comment 4 Joseph Pecoraro 2016-08-15 20:08:08 PDT
Comment on attachment 286126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286126&action=review

> Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css:100
> -    left: 10px;
> +    left: 12px;

We should be very specific here:

  • On my Non-retina OS X El Capitan machine this needs to be left: 13px to align perfectly with the text.
  • On my Retina macOS Sierra machine this needs to be left: 13px  to align perfectly with the text.

What system were you on where 12px was optimal. Maybe we need to make platform/configuration specific values? Or maybe there is a system setting that nudges it 1px for you?
Comment 5 Devin Rousso 2016-08-16 23:00:25 PDT
Created attachment 286278 [details]
Patch
Comment 6 Devin Rousso 2016-08-16 23:04:00 PDT
(In reply to comment #4)
> We should be very specific here:
> 
>   • On my Non-retina OS X El Capitan machine this needs to be left: 13px to
> align perfectly with the text.
>   • On my Retina macOS Sierra machine this needs to be left: 13px  to align
> perfectly with the text.
> 
> What system were you on where 12px was optimal. Maybe we need to make
> platform/configuration specific values? Or maybe there is a system setting
> that nudges it 1px for you?

Not really sure why, but it looked right when I tried it yesterday.  I tried moving the window around and changing resolution, but 13px always looked exactly right ¯\_(ツ)_/¯
Comment 7 Devin Rousso 2016-08-17 13:52:37 PDT
Created attachment 286326 [details]
[Image] After Patch is applied
Comment 8 Timothy Hatcher 2016-08-17 14:01:22 PDT
Comment on attachment 286278 [details]
Patch

Yes!
Comment 9 WebKit Commit Bot 2016-08-17 14:22:37 PDT
Comment on attachment 286278 [details]
Patch

Clearing flags on attachment: 286278

Committed r204571: <http://trac.webkit.org/changeset/204571>
Comment 10 WebKit Commit Bot 2016-08-17 14:22:41 PDT
All reviewed patches have been landed.  Closing bug.