Bug 160882 - webkitpy error in TestRunResults.merge()
Summary: webkitpy error in TestRunResults.merge()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-15 17:14 PDT by Simon Fraser (smfr)
Modified: 2016-08-15 23:43 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2016-08-15 17:16 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-08-15 17:14:28 PDT
webkitpy error in TestRunResults.merge()
Comment 1 Simon Fraser (smfr) 2016-08-15 17:16:03 PDT
Created attachment 286122 [details]
Patch
Comment 2 Daniel Bates 2016-08-15 17:18:12 PDT
Comment on attachment 286122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286122&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:100
>      def merge(self, test_run_results):
> +        if not test_run_results:
> +            return self
>          # self.expectations should be the same for both
>          self.total += test_run_results.total

We should consider writing a test for this logic.
Comment 3 Alexey Proskuryakov 2016-08-15 22:54:59 PDT
Comment on attachment 286122 [details]
Patch

cq+ to unbreak EWS.
Comment 4 WebKit Commit Bot 2016-08-15 23:43:10 PDT
Comment on attachment 286122 [details]
Patch

Clearing flags on attachment: 286122

Committed r204498: <http://trac.webkit.org/changeset/204498>
Comment 5 WebKit Commit Bot 2016-08-15 23:43:15 PDT
All reviewed patches have been landed.  Closing bug.