Bug 160875 - Web Inspector: Error/Warning icons are misplaced in the Visual sidebar
Summary: Web Inspector: Error/Warning icons are misplaced in the Visual sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-15 16:32 PDT by Devin Rousso
Modified: 2016-08-15 18:36 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.21 KB, patch)
2016-08-15 16:35 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] Screenshot of issue (7.09 KB, image/png)
2016-08-15 16:37 PDT, Devin Rousso 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-08-15 16:32:17 PDT 
For Visual style property editors that do not have a title element, the error/warning icon before the editor element is not evenly spaced.
Comment 1 Radar WebKit Bug Importer 2016-08-15 16:32:50 PDT 
<rdar://problem/27856725>
Comment 2 Devin Rousso 2016-08-15 16:35:39 PDT 
Created attachment 286114 [details]
Patch
Comment 3 Devin Rousso 2016-08-15 16:37:03 PDT 
Created attachment 286116 [details]
[Image] Screenshot of issue
Comment 4 Matt Baker 2016-08-15 18:14:09 PDT 
Comment on attachment 286114 [details]
Patch

Looks good. Filed a follow-up for an issue that came up during testing: https://bugs.webkit.org/show_bug.cgi?id=160887.
Comment 5 WebKit Commit Bot 2016-08-15 18:36:10 PDT 
Comment on attachment 286114 [details]
Patch

Clearing flags on attachment: 286114

Committed r204490: <http://trac.webkit.org/changeset/204490>
Comment 6 WebKit Commit Bot 2016-08-15 18:36:14 PDT 
All reviewed patches have been landed.  Closing bug.