Bug 160872 - Web Inspector: Make an icon for Code Coverage Profiler
Summary: Web Inspector: Make an icon for Code Coverage Profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks: 160973
  Show dependency tree / graph
 
Reported: 2016-08-15 15:42 PDT by Nikita Vasilyev
Modified: 2016-08-19 15:34 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2016-08-18 16:50 PDT, Nikita Vasilyev 		joepeck: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
[Image] C icon (14.39 KB, image/png)
2016-08-18 16:50 PDT, Nikita Vasilyev 		no flags Details
[Image] C icon @1x (4.03 KB, image/png)
2016-08-19 12:19 PDT, Nikita Vasilyev 		no flags Details
Patch (1.46 KB, patch)
2016-08-19 12:24 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-08-15 15:42:32 PDT 
This icon should be right next to [T] icon, that toggles Type Profiler.
Comment 1 Radar WebKit Bug Importer 2016-08-15 15:43:07 PDT 
<rdar://problem/27855650>
Comment 2 Nikita Vasilyev 2016-08-18 16:50:14 PDT 
Created attachment 286412 [details]
Patch
Comment 3 Nikita Vasilyev 2016-08-18 16:50:42 PDT 
Created attachment 286413 [details]
[Image] C icon
Comment 4 Nikita Vasilyev 2016-08-18 17:02:26 PDT 
To answer possible copyright questions:
I drew this "C" in Photoshop. I didn't use any existing fonts.
Comment 5 Joseph Pecoraro 2016-08-18 17:56:40 PDT 
Comment on attachment 286412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286412&action=review

Looks good! I assume you took a look on non-Retain too and it looked fine?

File name is a bit weird. "Code Coverage" seems better than "Control Flow".

> Source/WebInspectorUI/UserInterface/Images/NavigationItemControlFlow.svg:5
> +    <path fill="none" stroke="currentColor" stroke-width="1" d="M9,5.5s0-1.5-2.5-1.5C3,4,3,10,6.5,10c2.5,0,2.5-1.5,2.5-1.5"/>

This style for path is to use spaces not commas.
Comment 6 Nikita Vasilyev 2016-08-19 12:19:34 PDT 
Created attachment 286467 [details]
[Image] C icon @1x

Pixel hinting isn't great, but I'd rather land this first and polish it later if we decide to stick with this icon.
Comment 7 Nikita Vasilyev 2016-08-19 12:24:12 PDT 
Created attachment 286468 [details]
Patch
Comment 8 WebKit Commit Bot 2016-08-19 12:35:02 PDT 
Comment on attachment 286468 [details]
Patch

Clearing flags on attachment: 286468

Committed r204646: <http://trac.webkit.org/changeset/204646>
Comment 9 WebKit Commit Bot 2016-08-19 12:35:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Nikita Vasilyev 2016-08-19 13:10:57 PDT 
(In reply to comment #5)
> File name is a bit weird. "Code Coverage" seems better than "Control Flow".

We have RuntimeAgent.enableControlFlowProfiler. Are you okay with this name?
Or should it be enableCodeCoverageProfiler?
Comment 11 Joseph Pecoraro 2016-08-19 15:34:14 PDT 
(In reply to comment #10)
> (In reply to comment #5)
> > File name is a bit weird. "Code Coverage" seems better than "Control Flow".
> 
> We have RuntimeAgent.enableControlFlowProfiler. Are you okay with this name?
> Or should it be enableCodeCoverageProfiler?

I think code coverage profiler is better.