Bug 160868 – Placeholder does not show the first time going into picture-in-picture on video without controls

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ada Chan]

If you have HTML like the following:

<video id="test-video" src="..." autoplay></video>
<p><button onclick="document.getElementById('test-video').webkitSetPresentationMode('picture-in-picture')">Picture-in-picture</button></p>

The first time you click the button to go into picture-in-picture, the placeholder does not show. But it shows if you try it the second time.

[Ada Chan]

<rdar://problem/27804007>

[Ada Chan]

Created attachment 286098 [details]
Patch

[Eric Carlson]

Comment on attachment 286098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286098&action=review

> LayoutTests/media/controls/pip-placeholder-without-video-controls.html:7
> +            var maxAttemptsToTestPlaceholderVisibility = 100;

Nit: this seems excessive, it means the tests won't fail for 3.3 seconds. I think that we will have a problem if it takes more than a few retries, but maybe 10 is OK too allow for slow bots.

[Ada Chan]

I used 10 as the max retry count for a similar test before but Alexey suggested bumping it to 10 seconds which I thought was a bit excessive, so in this test I increased the number to 100.  But thinking about this more, 10 should probably be sufficient because it shouldn't take that long for the layer to be moved.  Changing it to 10.

Thanks for the review!

[Ada Chan]

Committed:
http://trac.webkit.org/changeset/204534