Bug 160858 – Rename SocketStreamHandleBase to SocketStreamHandle and SocketStreamHandle to SocketStreamHandleImpl

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Rename SocketStreamHandleBase to SocketStreamHandle and SocketStreamHandle to SocketStreamHandleImpl

[Alex Christensen]

Created attachment 286078 [details]
Patch

[WebKit Commit Bot]

Attachment 286078 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImpl.h:64:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImpl.h:101:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/network/SocketStreamHandle.cpp:38:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/platform/network/SocketStreamHandle.cpp:124:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/network/soup/SocketStreamHandleImpl.h:81:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/network/SocketStreamHandle.h:68:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:54:  "CFNetwork/CFNetwork.h" already included at Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:49  [build/include] [4]
ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:148:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:169:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:173:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:487:  Missing space before ( in switch(  [whitespace/parens] [5]
ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:559:  Missing space before ( in switch(  [whitespace/parens] [5]
ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:700:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 14 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 286079 [details]
Patch

[Alex Christensen]

Created attachment 286082 [details]
Patch

[Alex Christensen]

Created attachment 286085 [details]
Patch

[Alex Christensen]

Created attachment 286088 [details]
Patch

[Brady Eidson]

Comment on attachment 286088 [details]
Patch

Rubber-stamp based on it being a pure rename that we discussed in person.

[Alex Christensen]

https://trac.webkit.org/changeset/204483

[Alexey Proskuryakov]

Impl is an abbr :(

[Alex Christensen]

We have BlobRegistry, BlobRegistryProxy, and BlobRegistryImpl.  We will soon have SocketStreamHandle, SocketStreamHandleProxy, and SocketStreamHandleImpl.  If anyone suggests a better naming scheme, I will use it.