Bug 160856 - Web Inspector: Large class lists are not easily discoverable with "Classes" quick-toggle
Summary: Web Inspector: Large class lists are not easily discoverable with "Classes" q...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-15 12:17 PDT by Devin Rousso
Modified: 2016-08-15 22:15 PDT (History)
7 users (show)

See Also:

Attachments
[Image] Screenshot of issue (403.76 KB, image/png)
2016-08-15 12:17 PDT, Devin Rousso 		no flags Details
Patch (5.24 KB, patch)
2016-08-15 13:18 PDT, Devin Rousso 		joepeck: review+
Details | Formatted Diff | Diff
[Image] After Patch is applied (350.33 KB, image/png)
2016-08-15 13:19 PDT, Devin Rousso 		no flags Details
Patch (5.00 KB, patch)
2016-08-15 21:46 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-08-15 12:17:52 PDT 
Created attachment 286075 [details]
[Image] Screenshot of issue

If an element has a lot of classes, it is hard to see that there are more classes in the "Classes" quick-toggle area
Comment 1 Devin Rousso 2016-08-15 13:18:47 PDT 
Created attachment 286083 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2016-08-15 13:19:06 PDT 
<rdar://problem/27852460>
Comment 3 Devin Rousso 2016-08-15 13:19:37 PDT 
Created attachment 286084 [details]
[Image] After Patch is applied
Comment 4 Joseph Pecoraro 2016-08-15 19:22:38 PDT 
Comment on attachment 286083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286083&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js:90
> +WebInspector.linkifyNodeReference = function(node, maxLength = Number.POSITIVE_INFINITY)

We normally just use Infinity instead of Number.POSITIVE_INFINITY.

But how about just keeping it undefined here and doing:

    var displayName = WebInspector.displayNameForNode(node);
    if (maxLength)
        displayName = displayName.truncate(maxLength)
    ...

It reduces the work in the common case (no truncate).
Comment 5 Devin Rousso 2016-08-15 21:46:37 PDT 
Created attachment 286149 [details]
Patch
Comment 6 WebKit Commit Bot 2016-08-15 22:15:51 PDT 
Comment on attachment 286149 [details]
Patch

Clearing flags on attachment: 286149

Committed r204496: <http://trac.webkit.org/changeset/204496>
Comment 7 WebKit Commit Bot 2016-08-15 22:15:58 PDT 
All reviewed patches have been landed.  Closing bug.