RESOLVED FIXED 160856
Web Inspector: Large class lists are not easily discoverable with "Classes" quick-toggle 
https://bugs.webkit.org/show_bug.cgi?id=160856
Summary Web Inspector: Large class lists are not easily discoverable with "Classes" q...
Devin Rousso
Reported 2016-08-15 12:17:52 PDT
Created attachment 286075 [details] [Image] Screenshot of issue If an element has a lot of classes, it is hard to see that there are more classes in the "Classes" quick-toggle area
Attachments
[Image] Screenshot of issue (403.76 KB, image/png)
2016-08-15 12:17 PDT, Devin Rousso 		no flags
Details
Patch (5.24 KB, patch)
2016-08-15 13:18 PDT, Devin Rousso 		joepeck: review+
DetailsFormatted DiffDiff
[Image] After Patch is applied (350.33 KB, image/png)
2016-08-15 13:19 PDT, Devin Rousso 		no flags
Details
Patch (5.00 KB, patch)
2016-08-15 21:46 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2016-08-15 13:18:47 PDT
Created attachment 286083 [details] Patch
Radar WebKit Bug Importer
Comment 2 2016-08-15 13:19:06 PDT
<rdar://problem/27852460>
Devin Rousso
Comment 3 2016-08-15 13:19:37 PDT
Created attachment 286084 [details] [Image] After Patch is applied
Joseph Pecoraro
Comment 4 2016-08-15 19:22:38 PDT
Comment on attachment 286083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286083&action=review r=me > Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js:90 > +WebInspector.linkifyNodeReference = function(node, maxLength = Number.POSITIVE_INFINITY) We normally just use Infinity instead of Number.POSITIVE_INFINITY. But how about just keeping it undefined here and doing: var displayName = WebInspector.displayNameForNode(node); if (maxLength) displayName = displayName.truncate(maxLength) ... It reduces the work in the common case (no truncate).
Devin Rousso
Comment 5 2016-08-15 21:46:37 PDT
Created attachment 286149 [details] Patch
WebKit Commit Bot
Comment 6 2016-08-15 22:15:51 PDT
Comment on attachment 286149 [details] Patch Clearing flags on attachment: 286149 Committed r204496: <http://trac.webkit.org/changeset/204496>
WebKit Commit Bot
Comment 7 2016-08-15 22:15:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.