Bug 16085 - Web Inspector's Network Timeline graph code clean up and misc. fixes
Summary: Web Inspector's Network Timeline graph code clean up and misc. fixes
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Timothy Hatcher
Depends on:
Reported: 2007-11-21 12:12 PST by Timothy Hatcher
Modified: 2007-11-21 15:40 PST (History)
0 users

See Also:

Patch (15.31 KB, patch)
2007-11-21 12:18 PST, Timothy Hatcher
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2007-11-21 12:12:19 PST
The Network Timeline graph code has a couple of problems.

- It defines a few global functions that should be nested or hanging off another object/prototype.
- It recomputes the segment percentages twice, once for the main pill and another time for the reflection.
- Sometimes the percentages will round down so the total is below 100%. (We already account for a total greater than 100%.)
- The pill shadow is drawn with a stoke on a pixel boundary, to achieve a blurry line. We should use the canvas shadow drawing properties.
Comment 1 Timothy Hatcher 2007-11-21 12:18:50 PST
Created attachment 17434 [details]
Comment 2 Timothy Hatcher 2007-11-21 12:20:02 PST
This patch also removes un-needed save/restore calls.
Comment 3 Adam Roben (:aroben) 2007-11-21 15:04:55 PST
Comment on attachment 17434 [details]

Comment 4 Timothy Hatcher 2007-11-21 15:40:45 PST
Landed in r27943. http://trac.webkit.org/projects/webkit/changeset/27943