Bug 160848 - [Cocoa] Remove deprecated _WKFormDelegate
Summary: [Cocoa] Remove deprecated _WKFormDelegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-14 16:04 PDT by mitz
Modified: 2016-08-14 17:04 PDT (History)
2 users (show)

See Also:

Attachments
Remove _WKFormDelegate (11.69 KB, patch)
2016-08-14 16:07 PDT, mitz 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2016-08-14 16:04:18 PDT 
Patch forthcoming.
Comment 1 mitz 2016-08-14 16:07:04 PDT 
Created attachment 286037 [details]
Remove _WKFormDelegate
Comment 2 Anders Carlsson 2016-08-14 16:41:33 PDT 
Comment on attachment 286037 [details]
Remove _WKFormDelegate

View in context: https://bugs.webkit.org/attachment.cgi?id=286037&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4655
> +@implementation WKWebView (WKBinaryCompatibilityWithIOS10)
> +
> +- (id <_WKInputDelegate>)_formDelegate
> +{
> +    return self._inputDelegate;
> +}
> +
> +- (void)_setFormDelegate:(id <_WKInputDelegate>)formDelegate
> +{
> +    self._inputDelegate = formDelegate;
> +}

Can we put this inside an #ifdef so it'll be easier to see when we can remove it?
Comment 3 WebKit Commit Bot 2016-08-14 17:04:05 PDT 
Comment on attachment 286037 [details]
Remove _WKFormDelegate

Clearing flags on attachment: 286037

Committed r204458: <http://trac.webkit.org/changeset/204458>
Comment 4 WebKit Commit Bot 2016-08-14 17:04:09 PDT 
All reviewed patches have been landed.  Closing bug.