Bug 160846 – [Cocoa] Remove deprecated _WKVisitedLinkProvider declarations that aren’t needed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

Patch forthcoming.

Created attachment 286031 [details]
Remove declarations

[WebKit Commit Bot]

Attachment 286031 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:759:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 286031 [details]
Remove declarations

View in context: https://bugs.webkit.org/attachment.cgi?id=286031&action=review

> Source/WebKit2/ChangeLog:10
> +          cateogry implementation, changed type to _WKVisitedLinkStore.

Typo here in the word category.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:38
> +#import "_WKVisitedLinkStore.h"

Do we need to include this header to compile the code below? I am surprised if we do, but maybe I am missing something.

> Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm:34
> +// Defined for binary compatibility with Safari in iOS 10.

Seems like this comment should go before even the @interface.

Comment on attachment 286031 [details]
Remove declarations

View in context: https://bugs.webkit.org/attachment.cgi?id=286031&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:38
>> +#import "_WKVisitedLinkStore.h"
> 
> Do we need to include this header to compile the code below? I am surprised if we do, but maybe I am missing something.

We need the declaration of _WKVisitedLinkStore to compile some of the code in this file which allocates an instance of that class.

Committed <https://trac.webkit.org/r204454>.