Bug 160822 - Remove always true JSC::Debugger::needPauseHandling virtual method
Summary: Remove always true JSC::Debugger::needPauseHandling virtual method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-12 14:31 PDT by Joseph Pecoraro
Modified: 2016-08-15 13:45 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.81 KB, patch)
2016-08-12 14:34 PDT, Joseph Pecoraro 		mark.lam: review+
Details | Formatted Diff | Diff
[PATCH] For Landing (4.42 KB, patch)
2016-08-12 14:40 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-08-12 14:31:11 PDT 
Remove always true JSC::Debugger::needPauseHandling virtual method
Comment 1 Joseph Pecoraro 2016-08-12 14:34:12 PDT 
Created attachment 285951 [details]
[PATCH] Proposed Fix
Comment 2 Mark Lam 2016-08-12 14:35:05 PDT 
Comment on attachment 285951 [details]
[PATCH] Proposed Fix

r=me
Comment 3 Joseph Pecoraro 2016-08-12 14:39:41 PDT 
Comment on attachment 285951 [details]
[PATCH] Proposed Fix

Oops forgot to include Debugger.h changes itself.
Comment 4 Joseph Pecoraro 2016-08-12 14:40:59 PDT 
Created attachment 285953 [details]
[PATCH] For Landing
Comment 5 WebKit Commit Bot 2016-08-12 15:55:11 PDT 
The commit-queue encountered the following flaky tests while processing attachment 285953 [details]:

The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2016-08-12 15:55:54 PDT 
The commit-queue encountered the following flaky tests while processing attachment 285953 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2016-08-12 16:46:18 PDT 
The commit-queue encountered the following flaky tests while processing attachment 285953 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2016-08-12 16:46:20 PDT 
The commit-queue encountered the following flaky tests while processing attachment 285953 [details]:

The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2016-08-12 18:12:54 PDT 
The commit-queue encountered the following flaky tests while processing attachment 285953 [details]:

The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2016-08-12 18:13:17 PDT 
The commit-queue encountered the following flaky tests while processing attachment 285953 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2016-08-12 18:54:46 PDT 
The commit-queue encountered the following flaky tests while processing attachment 285953 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2016-08-12 18:54:50 PDT 
The commit-queue encountered the following flaky tests while processing attachment 285953 [details]:

The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2016-08-12 20:07:08 PDT 
Comment on attachment 285953 [details]
[PATCH] For Landing

Clearing flags on attachment: 285953

Committed r204440: <http://trac.webkit.org/changeset/204440>