RESOLVED FIXED 160821
Rename DocumentLoadTiming and ResourceLoadTiming 
https://bugs.webkit.org/show_bug.cgi?id=160821
Summary Rename DocumentLoadTiming and ResourceLoadTiming
Johan K. Jensen
Reported 2016-08-12 14:29:02 PDT
Rename ResourceLoadTiming to reflect that it only has timing about the network request. Rename DocumentLoadTiming to handle generic timing information for both the main document and subresources.
Attachments
Patch (94.86 KB, patch)
2016-08-12 14:47 PDT, Johan K. Jensen 		no flags
DetailsFormatted DiffDiff
Patch (94.27 KB, patch)
2016-08-12 15:05 PDT, Johan K. Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Johan K. Jensen
Comment 1 2016-08-12 14:47:33 PDT
Created attachment 285954 [details] Patch
Alex Christensen
Comment 2 2016-08-12 14:53:57 PDT
Comment on attachment 285954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285954&action=review > Source/WebCore/CMakeLists.txt:1915 > + loader/LoadTiming.cpp This should be put in correct alphabetical order. > Source/WebCore/loader/DocumentLoader.h:259 > + void resetTiming() { m_loadTiming = LoadTiming(); } Does { } work? > Source/WebCore/loader/LoadTiming.h:27 > +#ifndef LoadTiming_h > +#define LoadTiming_h #pragma once > Source/WebCore/platform/network/NetworkLoadTiming.h:28 > +#ifndef NetworkLoadTiming_h > +#define NetworkLoadTiming_h #pragma once, as long as we're touching this file.
Johan K. Jensen
Comment 3 2016-08-12 15:05:45 PDT
Created attachment 285959 [details] Patch
WebKit Commit Bot
Comment 4 2016-08-12 15:54:59 PDT
Comment on attachment 285959 [details] Patch Clearing flags on attachment: 285959 Committed r204429: <http://trac.webkit.org/changeset/204429>
WebKit Commit Bot
Comment 5 2016-08-12 15:55:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.