Bug 160815 - Add HashCountedSet to TestWTFLibrary target
Summary: Add HashCountedSet to TestWTFLibrary target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-12 13:12 PDT by John Wilander
Modified: 2016-08-12 16:10 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2016-08-12 13:16 PDT, John Wilander
no flags Details | Formatted Diff | Diff
Patch (5.60 KB, patch)
2016-08-12 14:10 PDT, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2016-08-12 13:12:47 PDT
HashCountedSet is currently not part of any target and thus not run. It should be part of the TestWTFLibrary target.
Comment 1 John Wilander 2016-08-12 13:13:23 PDT
HashCountedSet tests in TestWebKitAPI that is.
Comment 2 John Wilander 2016-08-12 13:14:29 PDT
Changing component to Tools / Tests.
Comment 3 John Wilander 2016-08-12 13:16:48 PDT
Created attachment 285938 [details]
Patch
Comment 4 Daniel Bates 2016-08-12 13:36:54 PDT
Comment on attachment 285938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285938&action=review

HashCountedSet.cpp is already in Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (Is it in the wrong place?) See <https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj#L854> and <https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj#L1611>.

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2105
> +				6BFD29481D5E642E008EC968 /* HashCountedSet.cpp in Sources */,

Please insert this item such that it is in sorted order according to the UNIX sort command.
Comment 5 Daniel Bates 2016-08-12 13:40:19 PDT
(In reply to comment #4)
> Comment on attachment 285938 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285938&action=review
> 
> HashCountedSet.cpp is already in
> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (Is it in the
> wrong place?) See
> <https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/TestWebKitAPI.
> xcodeproj/project.pbxproj#L854> and
> <https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/TestWebKitAPI.
> xcodeproj/project.pbxproj#L1611>.
> 

Disregard this remark. As you mentioned in comment 0 HashCountedSet.cpp is not part of the target TestWTFLibrary.
Comment 6 John Wilander 2016-08-12 14:10:43 PDT
Created attachment 285946 [details]
Patch
Comment 7 John Wilander 2016-08-12 14:15:21 PDT
Thanks! I sorted that whole section as we discussed.
Comment 8 WebKit Commit Bot 2016-08-12 16:10:11 PDT
Comment on attachment 285946 [details]
Patch

Clearing flags on attachment: 285946

Committed r204430: <http://trac.webkit.org/changeset/204430>
Comment 9 WebKit Commit Bot 2016-08-12 16:10:15 PDT
All reviewed patches have been landed.  Closing bug.