Bug 160807 - Add test for fixed nullptr deref error
Summary: Add test for fixed nullptr deref error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-12 10:47 PDT by Brent Fulgham
Modified: 2016-08-26 23:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2016-08-12 10:50 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-08-12 10:47:05 PDT 
This bug just documents the addition of a test case that will help us avoid a nullptr dereference crash we encountered in MathML a few years ago.
Comment 1 Brent Fulgham 2016-08-12 10:50:46 PDT 
Created attachment 285919 [details]
Patch
Comment 2 Brent Fulgham 2016-08-12 11:51:35 PDT 
The Windows failure is unrelated to this patch.
Comment 3 Brent Fulgham 2016-08-12 11:53:55 PDT 
Committed in r204415 <https://trac.webkit.org/changeset/204415>.
Comment 4 Daniel Bates 2016-08-12 12:52:47 PDT 
Comment on attachment 285919 [details]
Patch

Clearing review flag as this change was committed per comment #3.
Comment 5 Daniel Bates 2016-08-12 12:53:38 PDT 
(In reply to comment #0)
> This bug just documents the addition of a test case that will help us avoid
> a nullptr dereference crash we encountered in MathML a few years ago.

Do we know the bug/changeset that fixed the MathML bug? If so, we should mark this bug as dependent on it.
Comment 6 Frédéric Wang (:fredw) 2016-08-26 23:36:24 PDT 
(In reply to comment #5)
> (In reply to comment #0)
> > This bug just documents the addition of a test case that will help us avoid
> > a nullptr dereference crash we encountered in MathML a few years ago.
> 
> Do we know the bug/changeset that fixed the MathML bug? If so, we should
> mark this bug as dependent on it.

A big refactoring has happened recently:
http://trac.webkit.org/wiki/MathML/Early_2016_Refactoring#Phase1

My guess would be r202168 (bug 153987).