Bug 160790 - [MediaStream] Add support for OverConstrained Error
Summary: [MediaStream] Add support for OverConstrained Error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
: 157839 161146 (view as bug list)
Depends on:
Blocks: 146746
  Show dependency tree / graph
 
Reported: 2016-08-11 17:33 PDT by George Ruan
Modified: 2016-10-30 13:19 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch. (18.20 KB, patch)
2016-08-24 11:06 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Proposed patch. (24.97 KB, patch)
2016-08-24 11:41 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Rebased patch. (19.49 KB, text/plain)
2016-08-24 12:40 PDT, Eric Carlson 		no flags Details
Proposed patch. (19.39 KB, patch)
2016-08-24 13:58 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George Ruan 2016-08-11 17:33:29 PDT 
https://w3c.github.io/mediacapture-main/#overconstrainederror-object Add support for the OverConstrainedError Object.

Blocks https://bugs.webkit.org/show_bug.cgi?id=146746, since it is a part of the getUserMedia() algorithm, step 6.3: https://w3c.github.io/mediacapture-main/#dom-mediadevices-getusermedia.
Comment 1 Radar WebKit Bug Importer 2016-08-11 17:34:43 PDT 
<rdar://problem/27815715>
Comment 2 George Ruan 2016-08-12 13:51:48 PDT 
*** Bug 157839 has been marked as a duplicate of this bug. ***
Comment 3 Eric Carlson 2016-08-24 10:55:34 PDT 
*** Bug 161146 has been marked as a duplicate of this bug. ***
Comment 4 Eric Carlson 2016-08-24 10:57:19 PDT 
The spec says that it should be possible to create an OverconstrainedError by calling it as a function as well as with new: "When OverconstrainedError is called as a function rather than as a constructor, it creates and initializes a new OverconstrainedError object". WebKit's bindings generator doesn't support this so we won't be able to do that in the first implementation.
Comment 5 Eric Carlson 2016-08-24 11:06:30 PDT 
Created attachment 286870 [details]
Proposed patch.
Comment 6 Eric Carlson 2016-08-24 11:41:23 PDT 
Created attachment 286875 [details]
Proposed patch.
Comment 7 Eric Carlson 2016-08-24 12:40:44 PDT 
Created attachment 286881 [details]
Rebased patch.
Comment 8 Eric Carlson 2016-08-24 13:58:43 PDT 
Created attachment 286889 [details]
Proposed patch.
Comment 9 WebKit Commit Bot 2016-08-24 14:57:12 PDT 
Comment on attachment 286889 [details]
Proposed patch.

Clearing flags on attachment: 286889

Committed r204935: <http://trac.webkit.org/changeset/204935>