Bug 160788 - Add WK2 ExperimentalFeature support to MiniBrowser
Summary: Add WK2 ExperimentalFeature support to MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-11 17:22 PDT by Brady Eidson
Modified: 2016-08-12 08:57 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.31 KB, patch)
2016-08-11 17:28 PDT, Brady Eidson
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-08-11 17:22:42 PDT
Add WK2 ExperimentalFeature support to MiniBrowser
Comment 1 Brady Eidson 2016-08-11 17:28:27 PDT
Created attachment 285873 [details]
Patch
Comment 2 Brady Eidson 2016-08-11 17:28:58 PDT
Forgot to mention, also makes Gamepads be an experimental feature.
Comment 3 Alex Christensen 2016-08-11 17:33:35 PDT
Comment on attachment 285873 [details]
Patch

r+, these should be separate patches.
Comment 5 Ryosuke Niwa 2016-08-11 22:29:35 PDT
It looks like this patch broke 32-bit Mac builds in which _WKExperimentalFeature is not defined. Maybe WK_API_ENABLED is false there?
Comment 6 Brady Eidson 2016-08-12 08:42:02 PDT
(In reply to comment #5)
> It looks like this patch broke 32-bit Mac builds in which
> _WKExperimentalFeature is not defined. Maybe WK_API_ENABLED is false there?

That's accurate.

Fixing.
Comment 7 Brady Eidson 2016-08-12 08:57:22 PDT
Attempted fix in https://trac.webkit.org/changeset/204411