WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
160788
Add WK2 ExperimentalFeature support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=160788
Summary
Add WK2 ExperimentalFeature support to MiniBrowser
Brady Eidson
Reported
2016-08-11 17:22:42 PDT
Add WK2 ExperimentalFeature support to MiniBrowser
Attachments
Patch
(8.31 KB, patch)
2016-08-11 17:28 PDT
,
Brady Eidson
achristensen
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
2016-08-11 17:28:27 PDT
Created
attachment 285873
[details]
Patch
Brady Eidson
Comment 2
2016-08-11 17:28:58 PDT
Forgot to mention, also makes Gamepads be an experimental feature.
Alex Christensen
Comment 3
2016-08-11 17:33:35 PDT
Comment on
attachment 285873
[details]
Patch r+, these should be separate patches.
Brady Eidson
Comment 4
2016-08-11 17:37:18 PDT
https://trac.webkit.org/changeset/204396
and
https://trac.webkit.org/changeset/204397
Ryosuke Niwa
Comment 5
2016-08-11 22:29:35 PDT
It looks like this patch broke 32-bit Mac builds in which _WKExperimentalFeature is not defined. Maybe WK_API_ENABLED is false there?
Brady Eidson
Comment 6
2016-08-12 08:42:02 PDT
(In reply to
comment #5
)
> It looks like this patch broke 32-bit Mac builds in which > _WKExperimentalFeature is not defined. Maybe WK_API_ENABLED is false there?
That's accurate. Fixing.
Brady Eidson
Comment 7
2016-08-12 08:57:22 PDT
Attempted fix in
https://trac.webkit.org/changeset/204411
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug