Bug 160781 - REGRESSION (r204264): Web Inspector: Uncaught Exception in Network tab when reloading a web page
Summary: REGRESSION (r204264): Web Inspector: Uncaught Exception in Network tab when r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Critical
Assignee: Nikita Vasilyev
URL: https://webkit.org/nightly/start/trun...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-11 13:31 PDT by Nikita Vasilyev
Modified: 2016-08-11 17:06 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2016-08-11 16:30 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-08-11 13:31:23 PDT 
-------
Inspected URL:        https://webkit.org/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/603.1.3+ (KHTML, like Gecko)

Uncaught Exceptions:
 - this._dataGrid.closed is not a function. (In 'this._dataGrid.closed()', 'this._dataGrid.closed' is undefined) (at NetworkGridContentView.js:157:30)
    closed @ NetworkGridContentView.js:157:30
    _disassociateFromContentView @ ContentViewContainer.js:476:27
    closeAllContentViews @ ContentViewContainer.js:339:46
    _networkTimelineReset @ NetworkSidebarPanel.js:183:70
    dispatch @ Object.js:162:30
    dispatchEventToListeners @ Object.js:169:17
    reset @ Timeline.js:80:42
    reset @ NetworkTimeline.js:41:20
    _mainResourceDidChange @ TimelineManager.js:807:50
    dispatch @ Object.js:162:30
    dispatchEventToListeners @ Object.js:177:21
    _dispatchMainResourceDidChangeEvent @ Frame.js:498:38
    commitProvisionalLoad @ Frame.js:140:53
    frameDidNavigate @ FrameResourceManager.js:105:40
    frameNavigated @ PageObserver.js:42:59
    dispatchEvent @ InspectorBackend.js:464:42
    _dispatchEvent @ InspectorBackend.js:358:32
    dispatch @ InspectorBackend.js:159:32
    dispatchNextQueuedMessageFromBackend @ MessageDispatcher.js:42:34

Additional Details:
    cause --> An uncaught exception was thrown while handling event: Page.frameNavigated
-------

* STEPS TO REPRODUCE
1. Open https://webkit.org/
2. Open Network tab.
3. Reload the page.
Comment 1 Radar WebKit Bug Importer 2016-08-11 13:31:48 PDT 
<rdar://problem/27810452>
Comment 2 Nikita Vasilyev 2016-08-11 13:50:53 PDT 
WebInspector.TimelineDataGrid.prototype.closed method was removed in
https://trac.webkit.org/changeset/204264

Joe, please take a look.
Comment 3 Matt Baker 2016-08-11 14:14:11 PDT 
"closed" gets implemented in a few class hierarchies, but never in DataGrid or View. I would just add an "implemented by subclasses" stub to DataGrid.
Comment 4 Nikita Vasilyev 2016-08-11 16:30:16 PDT 
Created attachment 285864 [details]
Patch
Comment 5 Matt Baker 2016-08-11 16:33:28 PDT 
r=me
Comment 6 WebKit Commit Bot 2016-08-11 17:06:38 PDT 
Comment on attachment 285864 [details]
Patch

Clearing flags on attachment: 285864

Committed r204391: <http://trac.webkit.org/changeset/204391>
Comment 7 WebKit Commit Bot 2016-08-11 17:06:42 PDT 
All reviewed patches have been landed.  Closing bug.