Bug 160781 – REGRESSION (r204264): Web Inspector: Uncaught Exception in Network tab when reloading a web page

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

-------
Inspected URL:        https://webkit.org/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/603.1.3+ (KHTML, like Gecko)

Uncaught Exceptions:
 - this._dataGrid.closed is not a function. (In 'this._dataGrid.closed()', 'this._dataGrid.closed' is undefined) (at NetworkGridContentView.js:157:30)
    closed @ NetworkGridContentView.js:157:30
    _disassociateFromContentView @ ContentViewContainer.js:476:27
    closeAllContentViews @ ContentViewContainer.js:339:46
    _networkTimelineReset @ NetworkSidebarPanel.js:183:70
    dispatch @ Object.js:162:30
    dispatchEventToListeners @ Object.js:169:17
    reset @ Timeline.js:80:42
    reset @ NetworkTimeline.js:41:20
    _mainResourceDidChange @ TimelineManager.js:807:50
    dispatch @ Object.js:162:30
    dispatchEventToListeners @ Object.js:177:21
    _dispatchMainResourceDidChangeEvent @ Frame.js:498:38
    commitProvisionalLoad @ Frame.js:140:53
    frameDidNavigate @ FrameResourceManager.js:105:40
    frameNavigated @ PageObserver.js:42:59
    dispatchEvent @ InspectorBackend.js:464:42
    _dispatchEvent @ InspectorBackend.js:358:32
    dispatch @ InspectorBackend.js:159:32
    dispatchNextQueuedMessageFromBackend @ MessageDispatcher.js:42:34

Additional Details:
    cause --> An uncaught exception was thrown while handling event: Page.frameNavigated
-------

* STEPS TO REPRODUCE
1. Open https://webkit.org/
2. Open Network tab.
3. Reload the page.

[Radar WebKit Bug Importer]

<rdar://problem/27810452>

[Nikita Vasilyev]

WebInspector.TimelineDataGrid.prototype.closed method was removed in
https://trac.webkit.org/changeset/204264

Joe, please take a look.

[Matt Baker]

"closed" gets implemented in a few class hierarchies, but never in DataGrid or View. I would just add an "implemented by subclasses" stub to DataGrid.

[Nikita Vasilyev]

Created attachment 285864 [details]
Patch

[Matt Baker]

r=me

[WebKit Commit Bot]

Comment on attachment 285864 [details]
Patch

Clearing flags on attachment: 285864

Committed r204391: <http://trac.webkit.org/changeset/204391>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.