RESOLVED FIXED 160777
Align Range.surroundContents() with the latest DOM specification 
https://bugs.webkit.org/show_bug.cgi?id=160777
Summary Align Range.surroundContents() with the latest DOM specification
Chris Dumez
Reported 2016-08-11 13:08:52 PDT
Align Range.surroundContents() with the latest DOM specification: - https://dom.spec.whatwg.org/#dom-range-surroundcontents This would get us much closer to Firefox's behavior.
Attachments
Patch (136.89 KB, patch)
2016-08-11 13:37 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 (677.70 KB, application/zip)
2016-08-11 14:48 PDT, Build Bot 		no flags
Details
Patch (143.66 KB, patch)
2016-08-11 14:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-11 13:37:16 PDT
Created attachment 285850 [details] Patch
Ryosuke Niwa
Comment 2 2016-08-11 14:36:51 PDT
Comment on attachment 285850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285850&action=review > LayoutTests/platform/mac/fast/dom/Range/surroundContents-1-expected.txt:8 > text run at (0,0) width 564: "This tests for HIERARCHY_REQUEST_ERRs when calling Range::surroundContents." Can we convert this test to a dump-as-markup.js test?
Build Bot
Comment 3 2016-08-11 14:48:56 PDT
Comment on attachment 285850 [details] Patch Attachment 285850 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1853617 New failing tests: fast/dom/Range/surroundContents-1.html
Build Bot
Comment 4 2016-08-11 14:48:59 PDT
Created attachment 285855 [details] Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Chris Dumez
Comment 5 2016-08-11 14:57:56 PDT
Created attachment 285856 [details] Patch
WebKit Commit Bot
Comment 6 2016-08-11 15:28:48 PDT
Comment on attachment 285856 [details] Patch Clearing flags on attachment: 285856 Committed r204390: <http://trac.webkit.org/changeset/204390>
WebKit Commit Bot
Comment 7 2016-08-11 15:28:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.