Bug 160777 - Align Range.surroundContents() with the latest DOM specification
Summary: Align Range.surroundContents() with the latest DOM specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#dom-rang...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-08-11 13:08 PDT by Chris Dumez
Modified: 2016-08-11 15:28 PDT (History)
9 users (show)

See Also:


Attachments
Patch (136.89 KB, patch)
2016-08-11 13:37 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 (677.70 KB, application/zip)
2016-08-11 14:48 PDT, Build Bot
no flags Details
Patch (143.66 KB, patch)
2016-08-11 14:57 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-08-11 13:08:52 PDT
Align Range.surroundContents() with the latest DOM specification:
- https://dom.spec.whatwg.org/#dom-range-surroundcontents

This would get us much closer to Firefox's behavior.
Comment 1 Chris Dumez 2016-08-11 13:37:16 PDT
Created attachment 285850 [details]
Patch
Comment 2 Ryosuke Niwa 2016-08-11 14:36:51 PDT
Comment on attachment 285850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285850&action=review

> LayoutTests/platform/mac/fast/dom/Range/surroundContents-1-expected.txt:8
>            text run at (0,0) width 564: "This tests for HIERARCHY_REQUEST_ERRs when calling Range::surroundContents."

Can we convert this test to a dump-as-markup.js test?
Comment 3 Build Bot 2016-08-11 14:48:56 PDT
Comment on attachment 285850 [details]
Patch

Attachment 285850 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1853617

New failing tests:
fast/dom/Range/surroundContents-1.html
Comment 4 Build Bot 2016-08-11 14:48:59 PDT
Created attachment 285855 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 5 Chris Dumez 2016-08-11 14:57:56 PDT
Created attachment 285856 [details]
Patch
Comment 6 WebKit Commit Bot 2016-08-11 15:28:48 PDT
Comment on attachment 285856 [details]
Patch

Clearing flags on attachment: 285856

Committed r204390: <http://trac.webkit.org/changeset/204390>
Comment 7 WebKit Commit Bot 2016-08-11 15:28:55 PDT
All reviewed patches have been landed.  Closing bug.