Bug 160772 - Don't append result of makeString
Summary: Don't append result of makeString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-11 11:45 PDT by Alex Christensen
Modified: 2016-08-11 17:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.85 KB, patch)
2016-08-11 11:49 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (33.67 KB, patch)
2016-08-11 12:09 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (30.74 KB, patch)
2016-08-11 13:34 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-08-11 11:45:56 PDT 
Don't append result of makeString
Comment 1 Alex Christensen 2016-08-11 11:49:00 PDT 
Created attachment 285839 [details]
Patch
Comment 2 Sam Weinig 2016-08-11 11:59:02 PDT 
Comment on attachment 285839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285839&action=review

> Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:134
> +    builder.append("Object store: ");

You want appendLiteral here.

> Source/WebKit2/Shared/Gamepad/GamepadData.cpp:66
> +    builder.append(" axes, ");

You want appendLiteral here.

> Source/WebKit2/Shared/Gamepad/GamepadData.cpp:68
> +    builder.append(" buttons\n");

You want appendLiteral here.

> Source/WebKit2/Shared/Gamepad/GamepadData.cpp:71
> +        builder.append(" Axis ");

You want appendLiteral here.

> Source/WebKit2/Shared/Gamepad/GamepadData.cpp:73
> +        builder.append(": ");

You want appendLiteral here.

> Source/WebKit2/Shared/Gamepad/GamepadData.cpp:79
> +        builder.append(" Button ");

You want appendLiteral here.

> Source/WebKit2/Shared/Gamepad/GamepadData.cpp:81
> +        builder.append(": ");

You want appendLiteral here.
Comment 3 Alex Christensen 2016-08-11 12:09:33 PDT 
Created attachment 285842 [details]
Patch
Comment 4 Alex Christensen 2016-08-11 13:34:49 PDT 
Created attachment 285849 [details]
Patch
Comment 5 WebKit Commit Bot 2016-08-11 17:35:17 PDT 
Comment on attachment 285849 [details]
Patch

Clearing flags on attachment: 285849

Committed r204394: <http://trac.webkit.org/changeset/204394>
Comment 6 WebKit Commit Bot 2016-08-11 17:35:21 PDT 
All reviewed patches have been landed.  Closing bug.