Bug 160768 – Rename LOG_ALWAYS

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Keith Rollin]

LOG_ALWAYS and friends should be renamed, given that the first parameter to it is a boolean expression that determines whether or not logging should be performed.

The macros are changed as follows:

LOG_ALWAYS(bool, format, ...) -> LOG_IF(bool, format, ...)
LOG_ALWAYS_ERROR(bool, format, ...) -> LOG_ERROR_IF(bool, format, ...)

The following macros are added:

LOG_ALWAYS(format, ...)
LOG_ERROR_ALWAYS(format, ...)

The sites calling these macros are also updated. Macros like:

#define DOWNLOAD_LOG_ALWAYS(...) LOG_ALWAYS(isAlwaysOnLoggingAllowed(), __VA_ARGS__)
#define DOWNLOAD_LOG_ALWAYS_ERROR(...) LOG_ALWAYS_ERROR(isAlwaysOnLoggingAllowed(), __VA_ARGS__)

are changed to:

#define LOG_IF_ALLOWED(...) LOG_IF(isAlwaysOnLoggingAllowed(), __VA_ARGS__)
#define LOG_ERROR_IF_ALLOWED(...) LOG_ERROR_IF(isAlwaysOnLoggingAllowed(), __VA_ARGS__)

Thus, instead of having file-specific macros for conditional logging, we have uniformly named macros. This relieves the developer from trying to remember while macros to be used for the specific file they're working in.

[Keith Rollin]

Created attachment 285865 [details]
Patch

[Keith Rollin]

Gavin suggests macro names following the pattern RELEASE_LOG_*. Updating my changes accordingly.

[Keith Rollin]

Created attachment 285985 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 285985 [details]
Patch

Clearing flags on attachment: 285985

Committed r204472: <http://trac.webkit.org/changeset/204472>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.