By bumping our JHBuild openwebrtc version we need some changes in the media player.
Created attachment 285821 [details] patch
Comment on attachment 285821 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=285821&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:346 > + m_videoSink = sink; > +#else > + GstElement* sink = gst_bin_new(nullptr); > + GstElement* gldownload = gst_element_factory_make("gldownload", nullptr); > + GstElement* videoconvert = gst_element_factory_make("videoconvert", nullptr); > + GstElement* webkitSink = MediaPlayerPrivateGStreamerBase::createVideoSink(); > + gst_bin_add_many(GST_BIN(sink), gldownload, videoconvert, webkitSink, nullptr); > + gst_element_link_many(gldownload, videoconvert, webkitSink, nullptr); > + GRefPtr<GstPad> pad = gst_element_get_static_pad(gldownload, "sink"); > + gst_element_add_pad(sink, gst_ghost_pad_new("sink", pad.get())); Why are we keeping the m_videoSink for the if and not for the else?
Comment on attachment 285821 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=285821&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:346 >> + gst_element_add_pad(sink, gst_ghost_pad_new("sink", pad.get())); > > Why are we keeping the m_videoSink for the if and not for the else? Because in the else m_videoSink is set from the ::createVideoSink method.
Committed r204409: <http://trac.webkit.org/changeset/204409>