Bug 160757 - [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
Summary: [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-10 16:31 PDT by Simon Fraser (smfr)
Modified: 2016-08-10 17:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (33.36 KB, patch)
2016-08-10 16:35 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-08-10 16:31:27 PDT 
[iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
Comment 1 Simon Fraser (smfr) 2016-08-10 16:35:19 PDT 
Created attachment 285782 [details]
Patch
Comment 2 Tim Horton 2016-08-10 16:54:13 PDT 
Comment on attachment 285782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285782&action=review

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:103
> +    const CGFloat statusBarHeight = 20;

Ideally this would use either [[UIApplication sharedApplication] statusBarFrame] or the VC's topLayoutGuide.

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:117
> +    UIViewController *viewController = [[UIViewController alloc] initWithNibName:nil bundle:nil];

You can just "init", I think.
Comment 3 Simon Fraser (smfr) 2016-08-10 17:11:33 PDT 
https://trac.webkit.org/r204364