Bug 160750 – Web Inspector: Introduce a method to enable code coverage profiler without enabling type profiler

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

RuntimeAgent.enableTypeProfiler() currently enables both type profiler AND code coverage profiler (for grayed out unexecuted code).

RuntimeAgent.enableTypeProfiler should only enable type profiler.

We should introduce a new method to enable code coverage profiler, e.g. RuntimeAgent.enableCodeCoverageProfiler().

[Radar WebKit Bug Importer]

<rdar://problem/27793469>

[Saam Barati]

Created attachment 285996 [details]
patch

[Joseph Pecoraro]

Comment on attachment 285996 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285996&action=review

r=me

> Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp:327
> +    setControlFlowProfilerEnabledState(true);

This should set the state to `false`.

[Saam Barati]

Comment on attachment 285996 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285996&action=review

>> Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp:327
>> +    setControlFlowProfilerEnabledState(true);
> 
> This should set the state to `false`.

Oops. Thanks for pointing this out.

[Saam Barati]

Created attachment 286104 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 286104 [details]
patch for landing

Clearing flags on attachment: 286104

Committed r204489: <http://trac.webkit.org/changeset/204489>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.