Bug 160750 - Web Inspector: Introduce a method to enable code coverage profiler without enabling type profiler
Summary: Web Inspector: Introduce a method to enable code coverage profiler without en...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 151695
  Show dependency tree / graph
 
Reported: 2016-08-10 14:39 PDT by Nikita Vasilyev
Modified: 2016-08-15 16:33 PDT (History)
11 users (show)

See Also:

Attachments
patch (8.01 KB, patch)
2016-08-12 19:22 PDT, Saam Barati 		joepeck: review+
Details | Formatted Diff | Diff
patch for landing (7.98 KB, patch)
2016-08-15 15:46 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-08-10 14:39:51 PDT 
RuntimeAgent.enableTypeProfiler() currently enables both type profiler AND code coverage profiler (for grayed out unexecuted code).

RuntimeAgent.enableTypeProfiler should only enable type profiler.

We should introduce a new method to enable code coverage profiler, e.g. RuntimeAgent.enableCodeCoverageProfiler().
Comment 1 Radar WebKit Bug Importer 2016-08-10 14:40:19 PDT 
<rdar://problem/27793469>
Comment 2 Saam Barati 2016-08-12 19:22:58 PDT 
Created attachment 285996 [details]
patch
Comment 3 Joseph Pecoraro 2016-08-12 19:31:49 PDT 
Comment on attachment 285996 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285996&action=review

r=me

> Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp:327
> +    setControlFlowProfilerEnabledState(true);

This should set the state to `false`.
Comment 4 Saam Barati 2016-08-12 22:52:16 PDT 
Comment on attachment 285996 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285996&action=review

>> Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp:327
>> +    setControlFlowProfilerEnabledState(true);
> 
> This should set the state to `false`.

Oops. Thanks for pointing this out.
Comment 5 Saam Barati 2016-08-15 15:46:02 PDT 
Created attachment 286104 [details]
patch for landing
Comment 6 WebKit Commit Bot 2016-08-15 16:33:38 PDT 
Comment on attachment 286104 [details]
patch for landing

Clearing flags on attachment: 286104

Committed r204489: <http://trac.webkit.org/changeset/204489>
Comment 7 WebKit Commit Bot 2016-08-15 16:33:43 PDT 
All reviewed patches have been landed.  Closing bug.