Bug 160749 - Baseline GetByVal and PutByVal for cache ID stubs need to handle exceptions
Summary: Baseline GetByVal and PutByVal for cache ID stubs need to handle exceptions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-10 14:31 PDT by Michael Saboff
Modified: 2016-08-10 16:46 PDT (History)
4 users (show)

See Also:


Attachments
Patch (13.13 KB, patch)
2016-08-10 15:40 PDT, Michael Saboff
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2016-08-10 14:31:56 PDT
Both emitGetByValWithCachedId() and emitPutByValWithCachedId() make slow path calls via callOperation().  There are exception checks after the calls in callOperation() and those exception checks need to be linked to the exception handler code for the function that emits the stubs.
Comment 1 Michael Saboff 2016-08-10 14:32:35 PDT
<rdar://problem/27598428>
Comment 2 Michael Saboff 2016-08-10 15:40:34 PDT
Created attachment 285775 [details]
Patch

I tested this patch on Mac X86-64, Mac X86, iOS ARM and ARM64 using the added test.
Comment 3 Michael Saboff 2016-08-10 16:46:33 PDT
Committed r204362: <http://trac.webkit.org/changeset/204362>