Bug 160743 - Web Inspector: Can't click on the lower half of "S" icon in JavaScript Allocations timeline
Summary: Web Inspector: Can't click on the lower half of "S" icon in JavaScript Alloca...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-10 11:40 PDT by Nikita Vasilyev
Modified: 2016-08-10 12:37 PDT (History)
7 users (show)

See Also:


Attachments
[Animated GIF] Bug (32.12 KB, image/gif)
2016-08-10 11:40 PDT, Nikita Vasilyev
no flags Details
Patch (1.48 KB, patch)
2016-08-10 11:50 PDT, Nikita Vasilyev
timothy: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
[Animated GIF] With patch applied (289.72 KB, image/gif)
2016-08-10 11:54 PDT, Nikita Vasilyev
no flags Details
Patch (1.55 KB, patch)
2016-08-10 12:07 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-08-10 11:40:22 PDT
Created attachment 285737 [details]
[Animated GIF] Bug

Because it's covered by <div class="scroll-container">.
Comment 1 Radar WebKit Bug Importer 2016-08-10 11:40:45 PDT
<rdar://problem/27790098>
Comment 2 Nikita Vasilyev 2016-08-10 11:50:13 PDT
Created attachment 285738 [details]
Patch
Comment 3 Timothy Hatcher 2016-08-10 11:53:27 PDT
Comment on attachment 285738 [details]
Patch

Timelines will soon be able to be reordered, so the Allocations timeline will not always be the last one. Other Timeline record bars should be clickable in the future too. See bug 147236 for an older bug about this.

How does this affect the selection boxes? Are the dimmed areas behind or above the S icons?

We could land this as a workaround until bug 147236 is fixed. We should add a FIXME comment in that case.
Comment 4 Nikita Vasilyev 2016-08-10 11:54:31 PDT
Created attachment 285739 [details]
[Animated GIF] With patch applied
Comment 5 Nikita Vasilyev 2016-08-10 12:07:29 PDT
Created attachment 285741 [details]
Patch
Comment 6 WebKit Commit Bot 2016-08-10 12:37:08 PDT
Comment on attachment 285741 [details]
Patch

Clearing flags on attachment: 285741

Committed r204339: <http://trac.webkit.org/changeset/204339>
Comment 7 WebKit Commit Bot 2016-08-10 12:37:12 PDT
All reviewed patches have been landed.  Closing bug.