Bug 16074 - execCommand("InsertHorizontalRule", false, "") results in id="" being inserted
Summary: execCommand("InsertHorizontalRule", false, "") results in id="" being inserted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Trivial
Assignee: Nobody
URL: http://bdash.net.nz/files/arguments-c...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-20 12:35 PST by Mark Rowe (bdash)
Modified: 2007-11-20 13:36 PST (History)
0 users

See Also:

Attachments
Patch (3.71 KB, patch)
2007-11-20 12:41 PST, Mark Rowe (bdash) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2007-11-20 12:35:55 PST 
http://bdash.net.nz/files/arguments-combinations.html is a test case using InsertOrderedList rather than InsertHorizontalRule.  You'll notice that a test is failing as InsertOrderedList does not insert id="" when the empty string is passed as the value argument.  According to the HTML 5 specification an empty id attribute is not valid.  I believe that InsertHorizontalRule should match InsertOrderedList/InsertUnorderedList on this point.
Comment 1 Mark Rowe (bdash) 2007-11-20 12:41:03 PST 
Created attachment 17419 [details]
Patch
Comment 2 Sam Weinig 2007-11-20 13:20:33 PST 
Comment on attachment 17419 [details]
Patch

I think a test of InsertOrderedList and InsertUnorderedList with an empty string 3rd parameter would be nice if it doesn't already exist. 

r=me.
Comment 3 Mark Rowe (bdash) 2007-11-20 13:36:45 PST 
Landed in r27931.