WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
160720
[JSC] Remove some useless code I left when rewriting CSE's large maps
https://bugs.webkit.org/show_bug.cgi?id=160720
Summary
[JSC] Remove some useless code I left when rewriting CSE's large maps
Benjamin Poulain
Reported
2016-08-09 17:09:37 PDT
[JSC] Remove some useless code I left when rewriting CSE's large maps
Attachments
Patch
(2.41 KB, patch)
2016-08-09 17:11 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2016-08-09 17:11:54 PDT
Created
attachment 285695
[details]
Patch
Michael Saboff
Comment 2
2016-08-09 17:16:03 PDT
Comment on
attachment 285695
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=285695&action=review
r=me
> Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:273 >
What is the purpose of the empty line?
Benjamin Poulain
Comment 3
2016-08-09 17:17:39 PDT
(In reply to
comment #2
)
> > Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:273 > > > > What is the purpose of the empty line?
The comment above only applies to the 2 attributes that follow. The empty line is there to show this attribute does not follow the comment.
Benjamin Poulain
Comment 4
2016-08-10 14:20:30 PDT
Comment on
attachment 285695
[details]
Patch Clearing flags on attachment: 285695 Committed
r204352
: <
http://trac.webkit.org/changeset/204352
>
Benjamin Poulain
Comment 5
2016-08-10 14:20:34 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug