Bug 160718 - Support MediaTrackConstraintSet and MediaTrackConstraints IDL definition
Summary: Support MediaTrackConstraintSet and MediaTrackConstraints IDL definition
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: George Ruan
URL:
Keywords: InRadar
Depends on:
Blocks: 160798
  Show dependency tree / graph
 
Reported: 2016-08-09 16:38 PDT by George Ruan
Modified: 2017-08-30 11:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (39.15 KB, patch)
2016-08-09 17:26 PDT, George Ruan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2016-08-09 16:39:17 PDT 
<rdar://problem/27776658>
Comment 2 George Ruan 2016-08-09 17:26:30 PDT 
Created attachment 285697 [details]
Patch
Comment 3 Chris Dumez 2016-08-09 19:29:39 PDT 
Comment on attachment 285697 [details]
Patch

Given how complex these dictionaries are and the way they are used, I feel it may be simpler for now to not bother with dictionaries at all in the IDL. We could just mark getConstaints() and applyConstraints() as [Custom] in the IDL (not declare any dictionaries in the IDL) and convert and do the JSValue <-> Internal Class conversion in the custom bindings. This way, you can declare your internal MediaTrackContraints class whatever way you like and make it convenient to use on native side. I think it is going to be a while until we can support such complex dictionaries in the bindings generator and the current struct it is able to generate is not very useful to us on native side and is very inconvenient to use.
Comment 4 George Ruan 2016-08-10 09:08:26 PDT 
OK, it does seem like the dictionary MediaTrackConstraintSet and MediaTrackConstraints will not help us all that much in parsing the data.

Doing it in Custom works.