Bug 160715 - Instantiate WebKit plug-ins at layout time, instead of at style resolution time
Summary: Instantiate WebKit plug-ins at layout time, instead of at style resolution time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-09 16:05 PDT by Anders Carlsson
Modified: 2016-08-09 18:32 PDT (History)
5 users (show)

See Also:

Attachments
Patch (22.94 KB, patch)
2016-08-09 16:07 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (23.06 KB, patch)
2016-08-09 16:18 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-08-09 16:05:11 PDT 
Instantiate WebKit plug-ins at layout time, instead of at style resolution time
Comment 1 Anders Carlsson 2016-08-09 16:07:46 PDT 
Created attachment 285684 [details]
Patch
Comment 2 Anders Carlsson 2016-08-09 16:18:26 PDT 
Created attachment 285686 [details]
Patch
Comment 3 Tim Horton 2016-08-09 17:36:35 PDT 
Comment on attachment 285686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285686&action=review

> Source/WebCore/html/HTMLEmbedElement.h:48
> +    void updateWidget(CreatePlugins) final;

You're changing the capitalization above but not here? :)

> Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1073
> +        return ObjectContentType::Frame; // Go ahead and hope that we can display the content.

Maybe remove the silly comment?
Comment 4 WebKit Commit Bot 2016-08-09 18:32:45 PDT 
Comment on attachment 285686 [details]
Patch

Clearing flags on attachment: 285686

Committed r204320: <http://trac.webkit.org/changeset/204320>
Comment 5 WebKit Commit Bot 2016-08-09 18:32:49 PDT 
All reviewed patches have been landed.  Closing bug.