Bug 160714 - Don't filter out the latest data point in chart data sampling
Summary: Don't filter out the latest data point in chart data sampling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-09 16:02 PDT by Ryosuke Niwa
Modified: 2016-08-09 16:23 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.78 KB, patch)
2016-08-09 16:20 PDT, Ryosuke Niwa
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-08-09 16:02:22 PDT
4/21/16, 4:30 PM Gavin Barraclough:
The dashboard page and the charts pages sample, and don’t show all datapoint.
Sometimes that means they don’t include the latest datapoint,
which means you can be looking at a chart page seeing a regression, when the newest datapoint would show it to be fixed!

Sampling is fine but it would be really nice if we could find a way to always include the single most recent result.
Comment 1 Ryosuke Niwa 2016-08-09 16:20:01 PDT
Created attachment 285687 [details]
Patch
Comment 2 Chris Dumez 2016-08-09 16:21:03 PDT
Comment on attachment 285687 [details]
Patch

r=me
Comment 3 Ryosuke Niwa 2016-08-09 16:23:32 PDT
Committed r204313: <http://trac.webkit.org/changeset/204313>